refactor: rename npm package to @onesignal/capacitor-plugin - #7
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
sherwinski
approved these changes
May 5, 2026
sherwinski
left a comment
There was a problem hiding this comment.
- We should add claude review
- Should we remove CodeQL? It's giving this error:
CodeQL could not process any code written in Java/Kotlin.
fadi-george
force-pushed
the
fg/rename
branch
2 times, most recently
from
May 5, 2026 18:15
7e3adb3 to
c1f8381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Rename the published npm package from
onesignal-capacitor-pluginto the scoped name@onesignal/capacitor-pluginand tighten the published file list.Details
Motivation
Move the plugin under the
@onesignalnpm scope to align with the rest of OneSignal's published packages, improve discoverability under the org, and make ownership/access management cleaner. While renaming, also fix that the previously published tarball was shipping the localandroid/.gradle/build cache (and other unintended files) by tightening thefilesallowlist inpackage.json.Scope
onesignal-capacitor-pluginto@onesignal/capacitor-plugin. This is a breaking install change but the public API surface, native target names, podspec, and SPM product (OnesignalCapacitorPlugin) are unchanged.examples/demo,examples/demo_pods) so they still build against the renamed package: dependency keys,node_modules/@onesignal/capacitor-pluginpaths in Capacitor's generated SPMPackage.swift,Podfile, andcapacitor.settings.gradle, plusexamples/setup.shandexamples/build.md.publishConfig.access: publicso the scoped package publishes publicly by default.filesinpackage.jsonto exact paths (dist,ios/Sources,android/src,android/build.gradle.kts,android/gradle,Package.swift,OneSignalCapacitorPlugin.podspec). Tarball goes from 44 files / ~50 kB packed / ~345 kB unpacked to 12 files / ~32 kB packed / ~199 kB unpacked.1.0.0).Migration note for consumers
Imports change from
from 'onesignal-capacitor-plugin'tofrom '@onesignal/capacitor-plugin'.Testing
Unit testing
vp test run— 11 files, 165 tests passing, 100% statements/lines coverage.Manual testing
vp check srcclean (format + lint + types).npm publish --dry-runconfirms tarball name@onesignal/capacitor-plugin@1.0.0, public access, and the trimmed file list (12 files, no.gradle/cache artifacts)..tgzworkflow aftersetup.shrename of theINSTALLED_DIRpath andvp removeargument.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor