ci: fix iOS SDK clone path collision in release workflow

When called from the iOS SDK repo, ../OneSignal-iOS-SDK resolves to the
workspace itself. Detect this and clone to $RUNNER_TEMP instead, passing
IOS_SDK_PATH to the update script.

Made-with: Cursor

Author: fadi-george

.github/workflows/create-release-pr.yml

@@ -66,9 +66,6 @@ jobs:
     name: Create Release PR
     needs: prep
     runs-on: macos-latest
-    defaults:
-      run:
-        working-directory: dotnet-sdk
     outputs:
       dotnet_from: ${{ steps.current_versions.outputs.dotnet_from }}
       android_from: ${{ steps.current_versions.outputs.android_from }}
@@ -81,7 +78,6 @@ jobs:
           repository: OneSignal/OneSignal-DotNet-SDK
           ref: ${{ needs.prep.outputs.release_branch }}
           token: ${{ secrets.GH_PUSH_TOKEN || github.token }}
-          path: dotnet-sdk
 
       - name: Setup Git User
         uses: OneSignal/sdk-shared/.github/actions/setup-git-user@main
@@ -111,7 +107,15 @@ jobs:
           # Clone iOS SDK if ios_version is provided
           if [ -n "${{ inputs.ios_version }}" ]; then
             echo "Cloning iOS SDK..."
-            git clone --branch ${{ inputs.ios_version }} --depth 1 https://github.com/OneSignal/OneSignal-iOS-SDK.git ../OneSignal-iOS-SDK
+            IOS_CLONE_PATH="../OneSignal-iOS-SDK"
+            # When called from the iOS SDK repo, ../OneSignal-iOS-SDK resolves to the
+            # workspace itself. Clone to a temp path and set IOS_SDK_PATH for the script.
+            RESOLVED=$(cd "$(dirname "$IOS_CLONE_PATH")" && echo "$(pwd)/$(basename "$IOS_CLONE_PATH")")
+            if [ "$RESOLVED" = "$(pwd)" ]; then
+              IOS_CLONE_PATH="${RUNNER_TEMP}/OneSignal-iOS-SDK"
+              export IOS_SDK_PATH="$IOS_CLONE_PATH"
+            fi
+            git clone --branch ${{ inputs.ios_version }} --depth 1 https://github.com/OneSignal/OneSignal-iOS-SDK.git "$IOS_CLONE_PATH"
           fi
 
           echo "Running update_native_binaries.sh..."

update_native_binaries.sh

@@ -7,6 +7,7 @@ set -e
 #         ./update_native_binaries.sh --android_native_version=5.1.37 --ios_native_version=5.2.14
 
 WORKING_DIR=$(pwd)
+IOS_SDK_PATH="${IOS_SDK_PATH:-../OneSignal-iOS-SDK}"
 
 # Parse input params from terminal
 for arg in "$@"; do
@@ -45,16 +46,16 @@ update_ios_binaries() {
     rm -rf OneSignalSDK.DotNet.iOS.Binding/OneSignalInAppMessages.xcframework/
     rm -rf OneSignalSDK.DotNet.iOS.Binding/OneSignalLocation.xcframework/
     rm -rf OneSignalSDK.DotNet.iOS.Binding/OneSignalLiveActivities.xcframework/
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_XCFramework/OneSignalFramework.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_Core/OneSignalCore.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_Extension/OneSignalExtension.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_Notifications/OneSignalNotifications.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_OSCore/OneSignalOSCore.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_Outcomes/OneSignalOutcomes.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_User/OneSignalUser.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_InAppMessages/OneSignalInAppMessages.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_Location/OneSignalLocation.xcframework"
-    move_ios_binary "../OneSignal-iOS-SDK/iOS_SDK/OneSignalSDK/OneSignal_LiveActivities/OneSignalLiveActivities.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_XCFramework/OneSignalFramework.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_Core/OneSignalCore.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_Extension/OneSignalExtension.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_Notifications/OneSignalNotifications.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_OSCore/OneSignalOSCore.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_Outcomes/OneSignalOutcomes.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_User/OneSignalUser.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_InAppMessages/OneSignalInAppMessages.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_Location/OneSignalLocation.xcframework"
+    move_ios_binary "${IOS_SDK_PATH}/iOS_SDK/OneSignalSDK/OneSignal_LiveActivities/OneSignalLiveActivities.xcframework"
 }
 
 update_android_binaries() {