chore: [SDK-4711] clean up .NET demo build warnings#185
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@claude review once |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@claude review once |
nan-li
approved these changes
Jun 26, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Clean up build warnings surfaced by the .NET demo builds without changing existing runtime contracts.
Details
Motivation
SDK-4711 tracks build warning cleanup for the .NET SDK demos. The goal is to keep demo builds warning-free across iOS and Android while preserving existing SDK behavior for nullable values and optional native modules.
Scope
This PR enables nullable annotations where they reflect existing behavior, fixes warning-producing authored code, and suppresses generated binding diagnostics in binding projects only. It also keeps existing null-return behavior for user IDs, push IDs/tokens, tag reads, and iOS native conversion helpers.
Other
Android binding warning cleanup removes legacy explicit framework references and scopes
NoWarnto binding projects. iOS generated binding warnings are suppressed in the binding project only.Testing
Unit testing
No unit tests were added; these changes are focused on build warnings, nullable annotations, generated binding diagnostics, and demo project build configuration.
Manual testing
Validated the demo builds locally:
dotnet build examples/demo/demo.csproj -f net10.0-ios --no-restoredotnet build examples/demo/demo.csproj -f net10.0-android --no-restoredotnet build examples/demo-no-location/demo-no-location.csproj -f net10.0-android --no-restoreAll completed with 0 warnings and 0 errors.
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor