Skip to content

Commit c4fa58d

Browse files
authored
fix: [SDK-4193] suppress unchecked cast warnings in Android bridge (#1129)
1 parent 63d7350 commit c4fa58d

File tree

4 files changed

+20
-12
lines changed

4 files changed

+20
-12
lines changed
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: Move Linear tickets to Deployed
2+
3+
on:
4+
release:
5+
types: [published, edited]
6+
7+
jobs:
8+
linear-deployed:
9+
uses: OneSignal/sdk-shared/.github/workflows/linear-deployed.yml@main
10+
with:
11+
release_body: ${{ github.event.release.body }}
12+
secrets:
13+
LINEAR_GITHUB_API_KEY: ${{ secrets.LINEAR_GITHUB_API_KEY }}

android/src/main/java/com/onesignal/flutter/OneSignalInAppMessages.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ else if (call.method.contentEquals("OneSignal#arePaused"))
5353
else replyNotImplemented(result);
5454
}
5555

56+
@SuppressWarnings("unchecked")
5657
private void addTriggers(MethodCall call, Result result) {
57-
// call.arguments is being casted to a Map<String, Object> so a try-catch with
58-
// a ClassCastException will be thrown
5958
try {
6059
OneSignal.getInAppMessages().addTriggers((Map<String, String>) call.arguments);
6160
replySuccess(result, null);
@@ -73,9 +72,8 @@ private void removeTrigger(MethodCall call, Result result) {
7372
replySuccess(result, null);
7473
}
7574

75+
@SuppressWarnings("unchecked")
7676
private void removeTriggers(MethodCall call, Result result) {
77-
// call.arguments is being casted to a Collection<String> a try-catch with
78-
// a ClassCastException will be thrown
7977
try {
8078
OneSignal.getInAppMessages().removeTriggers((Collection<String>) call.arguments);
8179
replySuccess(result, null);

android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ public void onClick(INotificationClickEvent event) {
187187
}
188188
}
189189

190+
@SuppressWarnings("unchecked")
190191
private JSONObject getJsonFromMap(Map<String, Object> map) throws JSONException {
191192
JSONObject jsonData = new JSONObject();
192193
for (String key : map.keySet()) {

android/src/main/java/com/onesignal/flutter/OneSignalUser.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,8 @@ private void getExternalId(MethodCall call, Result result) {
8282
replySuccess(result, externalId);
8383
}
8484

85+
@SuppressWarnings("unchecked")
8586
private void addAliases(MethodCall call, Result result) {
86-
// call.arguments is being casted to a Map<String, Object> so a try-catch with
87-
// a ClassCastException will be thrown
8887
try {
8988
OneSignal.getUser().addAliases((Map<String, String>) call.arguments);
9089
replySuccess(result, null);
@@ -97,9 +96,8 @@ private void addAliases(MethodCall call, Result result) {
9796
}
9897
}
9998

99+
@SuppressWarnings("unchecked")
100100
private void removeAliases(MethodCall call, Result result) {
101-
// call.arguments is being casted to a List<String> so a try-catch with
102-
// a ClassCastException will be thrown
103101
try {
104102
OneSignal.getUser().removeAliases((List<String>) call.arguments);
105103
replySuccess(result, null);
@@ -132,9 +130,8 @@ private void removeSms(MethodCall call, Result result) {
132130
replySuccess(result, null);
133131
}
134132

133+
@SuppressWarnings("unchecked")
135134
private void addTags(MethodCall call, Result result) {
136-
// call.arguments is being casted to a Map<String, Object> so a try-catch with
137-
// a ClassCastException will be thrown
138135
try {
139136
OneSignal.getUser().addTags((Map<String, String>) call.arguments);
140137
replySuccess(result, null);
@@ -147,9 +144,8 @@ private void addTags(MethodCall call, Result result) {
147144
}
148145
}
149146

147+
@SuppressWarnings("unchecked")
150148
private void removeTags(MethodCall call, Result result) {
151-
// call.arguments is being casted to a List<String> so a try-catch with
152-
// a ClassCastException will be thrown
153149
try {
154150
OneSignal.getUser().removeTags((List<String>) call.arguments);
155151
replySuccess(result, null);

0 commit comments

Comments
 (0)