Skip to content

fix: [SDK-4722] guard getNotifications() in onDetachedFromEngine (#1149) #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
May 28, 2026
Merged

fix: [SDK-4722] guard getNotifications() in onDetachedFromEngine (#1149) #1150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e3d8d
fix(android): guard getNotifications() before init
fadi-george May 27, 2026
32b0007
chore: remove pull request template
fadi-george May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions .github/pull_request_template.md
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ public void onNotificationPermissionChange(boolean permission) {
}

void onDetachedFromEngine() {
// The Flutter engine can be torn down before OneSignal.initialize() has been
// called from Dart (cold start, fast finish, etc.). Calling getNotifications()
// in that state throws IllegalStateException from the native SDK. See #1149.
if (!OneSignal.isInitialized()) {
return;
}
// Unsubscribe so clicks while the engine is dead get queued by the native SDK
// instead of dispatched on a detached channel.
OneSignal.getNotifications().removeClickListener(this);
Expand Down
Loading