feat(deps): replace bundled EDM4U with UPM package

Author: fadi-george

.github/scripts/validate-unity-distribution.py

@@ -17,6 +17,9 @@
     "com.onesignal.unitysdk.ios",
 )
 CORE_PACKAGE = PACKAGE_NAMES[0]
+PLATFORM_PACKAGES = PACKAGE_NAMES[1:]
+EDM_PACKAGE = "com.unity.external-dependency-manager"
+EDM_VERSION = "2.0.0"
 MINIMUM_UNITY_VERSION = "2022.3"
 MINIMUM_UNITY_RELEASE = "0f1"
 
@@ -103,6 +106,14 @@ def validate_packages() -> None:
             if package.get("samples"):
                 fail(f"{name} must not contain samples")
 
+    for name in PLATFORM_PACKAGES:
+        if packages[name].get("dependencies", {}).get(EDM_PACKAGE) != EDM_VERSION:
+            fail(f"{name} does not depend on {EDM_PACKAGE}@{EDM_VERSION}")
+
+    legacy_installer = ROOT / CORE_PACKAGE / "Editor/SetupSteps/InstallEdm4uStep.cs"
+    if legacy_installer.exists():
+        fail(f"{legacy_installer.relative_to(ROOT)} installs unsupported Google EDM4U")
+
     manifest = json.loads((DEMO / "Packages/manifest.json").read_text())
     if manifest.get("scopedRegistries"):
         fail("demo requires a scoped registry")
@@ -152,6 +163,10 @@ def validate_sample() -> None:
 
 
 def main() -> None:
+    for project in (DEMO, ROOT / "examples/demo-no-location"):
+        legacy_edm = project / "Assets/ExternalDependencyManager"
+        if legacy_edm.exists():
+            fail(f"{legacy_edm.relative_to(ROOT)} bundles unsupported Google EDM4U")
     if (BOOTSTRAP / "Example").exists() or (BOOTSTRAP / "Example.meta").exists():
         fail("empty legacy Asset Store Example path still exists")
     if (BOOTSTRAP / "Documentation~").exists():

com.onesignal.unitysdk.android/LICENSE.md

@@ -111,19 +111,3 @@ Includes ShortcutBadger:
         WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
         See the License for the specific language governing permissions and
         limitations under the License.
-        
-    
-Includes unity-jar-resolver
-    Copyright (C) 2014 Google Inc.
- 
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
- 
-        http://www.apache.org/licenses/LICENSE-2.0
- 
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.

com.onesignal.unitysdk.android/package.json

@@ -6,7 +6,8 @@
   "unityRelease": "0f1",
   "description": "Android platform implementation for the OneSignal Unity SDK, including native dependency resolution and notification resources.",
   "dependencies": {
-    "com.onesignal.unitysdk.core": "6.0.0"
+    "com.onesignal.unitysdk.core": "6.0.0",
+    "com.unity.external-dependency-manager": "2.0.0"
   },
   "keywords": [
     "push-notifications",

com.onesignal.unitysdk.core/Editor/SetupSteps/InstallEdm4uStep.cs

@@ -111,19 +111,3 @@ Includes ShortcutBadger:
         WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
         See the License for the specific language governing permissions and
         limitations under the License.
-        
-    
-Includes unity-jar-resolver
-    Copyright (C) 2014 Google Inc.
- 
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
- 
-        http://www.apache.org/licenses/LICENSE-2.0
- 
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.

com.onesignal.unitysdk.core/Editor/SetupSteps/InstallEdm4uStep.cs.meta

@@ -96,7 +96,6 @@ public class BuildPostProcessor : IPostprocessBuildWithReport
         /// <summary>
         /// must be between 40 and 50 to ensure that it's not overriden by Podfile generation (40) and that it's
         /// added before "pod install" (50)
-        /// https://github.com/googlesamples/unity-jar-resolver#appending-text-to-generated-podfile
         /// </summary>
         public int callbackOrder => 45;
 

com.onesignal.unitysdk.core/LICENSE.md

@@ -111,19 +111,3 @@ Includes ShortcutBadger:
         WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
         See the License for the specific language governing permissions and
         limitations under the License.
-        
-    
-Includes unity-jar-resolver
-    Copyright (C) 2014 Google Inc.
- 
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
- 
-        http://www.apache.org/licenses/LICENSE-2.0
- 
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.

com.onesignal.unitysdk.ios/Editor/BuildPostProcessor.cs

@@ -6,7 +6,8 @@
   "unityRelease": "0f1",
   "description": "iOS platform implementation for the OneSignal Unity SDK, including the native bridge, CocoaPods dependencies, and Xcode post-processing.",
   "dependencies": {
-    "com.onesignal.unitysdk.core": "6.0.0"
+    "com.onesignal.unitysdk.core": "6.0.0",
+    "com.unity.external-dependency-manager": "2.0.0"
   },
   "keywords": [
     "push-notifications",