refactor(demo): simplify MaskValue and use em dash literal

Author: fadi-george

examples/demo/Assets/Scripts/UI/Sections/PushSectionController.cs

@@ -35,7 +35,7 @@ private VisualElement BuildSection()
 
             var pushIdRow = SectionBuilder.CreateInlineKeyValue(
                 "Push ID",
-                _viewModel.PushSubscriptionId ?? "\u2013",
+                _viewModel.PushSubscriptionId ?? "—",
                 "push_id"
             );
             _pushIdLabel = pushIdRow.Q<Label>("push_id_value");
@@ -71,7 +71,7 @@ private VisualElement BuildSection()
 
         public void Refresh()
         {
-            _pushIdLabel.text = _viewModel.PushSubscriptionId ?? "\u2013";
+            _pushIdLabel.text = _viewModel.PushSubscriptionId ?? "—";
             _enabledToggle.SetValueWithoutNotify(_viewModel.PushOptedIn);
             _enabledToggle.SetEnabled(_viewModel.HasPermission);
             _promptButton.style.display = _viewModel.HasPermission

examples/demo/Assets/Scripts/ViewModels/AppViewModel.cs

@@ -98,7 +98,7 @@ public void Init(PreferencesService prefs, OneSignalApiService apiService)
         }
 
         private static string MaskValue(string value) =>
-            string.IsNullOrEmpty(value) ? value : new string('\u2022', value.Length);
+            IsE2EMode && value != "—" ? new string('\u2022', value.Length) : value;
 
         private void OnDestroy()
         {
@@ -113,15 +113,15 @@ private void OnDestroy()
         public void LoadInitialState()
         {
             var rawAppId = _apiService?.GetAppId() ?? "";
-            _appId = IsE2EMode ? MaskValue(rawAppId) : rawAppId;
+            _appId = MaskValue(rawAppId);
             _consentRequired = _prefs.ConsentRequired;
             _privacyConsentGiven = _prefs.PrivacyConsent;
             _inAppMessagesPaused = _prefs.IamPaused;
             _locationShared = _prefs.LocationShared;
             _externalUserId = _prefs.ExternalUserId;
 
             var rawPushId = OneSignal.User.PushSubscription.Id ?? "";
-            _pushSubscriptionId = IsE2EMode ? MaskValue(rawPushId) : rawPushId;
+            _pushSubscriptionId = MaskValue(rawPushId);
             _pushOptedIn = OneSignal.User.PushSubscription.OptedIn;
             _hasPermission = OneSignal.Notifications.Permission;
 
@@ -583,7 +583,7 @@ public async Task FetchUserDataFromApi()
                 }
 
                 var rawPushId = OneSignal.User.PushSubscription.Id ?? "";
-                _pushSubscriptionId = IsE2EMode ? MaskValue(rawPushId) : rawPushId;
+                _pushSubscriptionId = MaskValue(rawPushId);
                 _pushOptedIn = OneSignal.User.PushSubscription.OptedIn;
                 _hasPermission = OneSignal.Notifications.Permission;
 
@@ -652,7 +652,7 @@ private static void MergeUnique(List<string> target, IEnumerable<string> source)
         private void OnPushSubscriptionChanged(object sender, PushSubscriptionChangedEventArgs e)
         {
             var rawPushId = OneSignal.User.PushSubscription.Id ?? "";
-            _pushSubscriptionId = IsE2EMode ? MaskValue(rawPushId) : rawPushId;
+            _pushSubscriptionId = MaskValue(rawPushId);
             _pushOptedIn = OneSignal.User.PushSubscription.OptedIn;
             Debug.Log($"[{Tag}] Push subscription changed: {rawPushId}");
             NotifyStateChanged();