Skip to content

Commit 0ea6f3e

Browse files
committed
use terser minifier
1 parent 7013e9d commit 0ea6f3e

8 files changed

Lines changed: 132 additions & 78 deletions

File tree

package-lock.json

Lines changed: 77 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"prettier": "3.6.2",
6666
"prettylint": "^2.0.0",
6767
"sass-embedded": "^1.89.2",
68+
"terser": "^5.43.1",
6869
"type-fest": "^4.41.0",
6970
"typescript": "^5.8.3",
7071
"vite": "^7.0.6",
@@ -76,17 +77,17 @@
7677
"size-limit": [
7778
{
7879
"path": "./build/releases/OneSignalSDK.page.js",
79-
"limit": "490 B",
80+
"limit": "450 B",
8081
"gzip": true
8182
},
8283
{
8384
"path": "./build/releases/OneSignalSDK.page.es6.js",
84-
"limit": "54.812 kB",
85+
"limit": "52.245 kB",
8586
"gzip": true
8687
},
8788
{
8889
"path": "./build/releases/OneSignalSDK.sw.js",
89-
"limit": "15.3 kB",
90+
"limit": "14.563 kB",
9091
"gzip": true
9192
},
9293
{

src/shared/libraries/Log.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { IS_SERVICE_WORKER, LOGGING } from '../utils/EnvVariables';
22

33
export default class Log {
4-
private static shouldLog(): boolean {
4+
private static _shouldLog(): boolean {
55
if (IS_SERVICE_WORKER)
66
return !!(self as unknown as ServiceWorkerGlobalScope).shouldLog;
77
try {
@@ -30,7 +30,7 @@ export default class Log {
3030

3131
private static createLogMethod(consoleMethod: keyof Console) {
3232
return (...args: unknown[]): void => {
33-
if (LOGGING || this.shouldLog() || consoleMethod === 'error') {
33+
if (LOGGING || this._shouldLog() || consoleMethod === 'error') {
3434
(console[consoleMethod] as (...args: unknown[]) => void)(...args);
3535
}
3636
};

src/shared/models/PermissionPromptType.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/shared/models/WindowEnvironmentKind.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

src/shared/slidedown/constants.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
export const SLIDEDOWN_CSS_CLASSES = {
2-
allowButton: 'onesignal-slidedown-allow-button',
32
body: 'slidedown-body',
43
buttonIndicatorHolder: 'onesignal-button-indicator-holder',
5-
cancelButton: 'onesignal-slidedown-cancel-button',
64
container: 'onesignal-slidedown-container',
75
dialog: 'onesignal-slidedown-dialog',
86
footer: 'slidedown-footer',

src/shared/useragent/detect.ts

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import { Browser } from './constants';
22
import type { BrowserValue } from './types';
33

44
interface BrowserConfig {
5-
name: string;
6-
pattern: RegExp;
7-
versionPattern: RegExp;
5+
_name: string;
6+
_pattern: RegExp;
7+
_versionPattern: RegExp;
88
}
99

1010
interface IBrowserResult {
@@ -15,67 +15,67 @@ interface IBrowserResult {
1515
// Top popular browsers set
1616
const BROWSER_CONFIGS: BrowserConfig[] = [
1717
{
18-
name: 'Opera',
19-
pattern: /(?:opera|opr|opios)/i,
20-
versionPattern: /(?:opera|opr|opios)[ /](\d+(?:\.\d+)?)/i,
18+
_name: 'Opera',
19+
_pattern: /(?:opera|opr|opios)/i,
20+
_versionPattern: /(?:opera|opr|opios)[ /](\d+(?:\.\d+)?)/i,
2121
},
2222
{
23-
name: 'Facebook',
24-
pattern: /FBAN\//i,
25-
versionPattern: /FBAV\/(\d+(?:\.\d+)?)/i,
23+
_name: 'Facebook',
24+
_pattern: /FBAN\//i,
25+
_versionPattern: /FBAV\/(\d+(?:\.\d+)?)/i,
2626
},
2727
{
28-
name: 'Samsung Browser',
29-
pattern: /samsungbrowser/i,
30-
versionPattern: /samsungbrowser[ /](\d+(?:\.\d+)?)/i,
28+
_name: 'Samsung Browser',
29+
_pattern: /samsungbrowser/i,
30+
_versionPattern: /samsungbrowser[ /](\d+(?:\.\d+)?)/i,
3131
},
3232
{
33-
name: 'Yandex Browser',
34-
pattern: /yabrowser/i,
35-
versionPattern: /yabrowser[ /](\d+(?:\.\d+)?)/i,
33+
_name: 'Yandex Browser',
34+
_pattern: /yabrowser/i,
35+
_versionPattern: /yabrowser[ /](\d+(?:\.\d+)?)/i,
3636
},
3737
{
38-
name: 'Vivaldi',
39-
pattern: /vivaldi/i,
40-
versionPattern: /vivaldi[ /](\d+(?:\.\d+)?)/i,
38+
_name: 'Vivaldi',
39+
_pattern: /vivaldi/i,
40+
_versionPattern: /vivaldi[ /](\d+(?:\.\d+)?)/i,
4141
},
4242
{
43-
name: 'UC Browser',
44-
pattern: /ucbrowser/i,
45-
versionPattern: /ucbrowser[ /](\d+(?:\.\d+)?)/i,
43+
_name: 'UC Browser',
44+
_pattern: /ucbrowser/i,
45+
_versionPattern: /ucbrowser[ /](\d+(?:\.\d+)?)/i,
4646
},
4747
{
48-
name: 'Microsoft Edge',
49-
pattern: /edg/i,
50-
versionPattern: /edg[ /](\d+(?:\.\d+)?)/i,
48+
_name: 'Microsoft Edge',
49+
_pattern: /edg/i,
50+
_versionPattern: /edg[ /](\d+(?:\.\d+)?)/i,
5151
},
5252
{
53-
name: 'Firefox',
54-
pattern: /firefox|iceweasel|fxios/i,
55-
versionPattern: /(?:firefox|iceweasel|fxios)[ /](\d+(?:\.\d+)?)/i,
53+
_name: 'Firefox',
54+
_pattern: /firefox|iceweasel|fxios/i,
55+
_versionPattern: /(?:firefox|iceweasel|fxios)[ /](\d+(?:\.\d+)?)/i,
5656
},
5757
{
58-
name: 'Chromium',
59-
pattern: /chromium/i,
60-
versionPattern: /chromium[ /](\d+(?:\.\d+)?)/i,
58+
_name: 'Chromium',
59+
_pattern: /chromium/i,
60+
_versionPattern: /chromium[ /](\d+(?:\.\d+)?)/i,
6161
},
6262
{
63-
name: 'Chrome',
64-
pattern: /chrome|crios|crmo/i,
65-
versionPattern: /(?:chrome|crios|crmo)[ /](\d+(?:\.\d+)?)/i,
63+
_name: 'Chrome',
64+
_pattern: /chrome|crios|crmo/i,
65+
_versionPattern: /(?:chrome|crios|crmo)[ /](\d+(?:\.\d+)?)/i,
6666
},
6767
{
68-
name: 'Safari',
69-
pattern: /safari|applewebkit/i,
70-
versionPattern: /version[ /](\d+(?:\.\d+)?)/i,
68+
_name: 'Safari',
69+
_pattern: /safari|applewebkit/i,
70+
_versionPattern: /version[ /](\d+(?:\.\d+)?)/i,
7171
},
7272
];
7373

7474
export function getBrowser(userAgent: string): IBrowserResult {
7575
for (const config of BROWSER_CONFIGS) {
76-
if (config.pattern.test(userAgent)) {
77-
const version = userAgent.match(config.versionPattern)?.[1] ?? '';
78-
return { name: config.name, version };
76+
if (config._pattern.test(userAgent)) {
77+
const version = userAgent.match(config._versionPattern)?.[1] ?? '';
78+
return { name: config._name, version };
7979
}
8080
}
8181
return { name: 'Unknown', version: '' };

vite.config.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,16 @@ export default defineConfig(({ mode }) => {
6060
* `var It=Object.defineProperty;` above the IIFE.
6161
*/
6262
target: 'es2022',
63-
minify: isProdEnv,
63+
minify: isProdEnv ? 'terser' : false,
64+
terserOptions: {
65+
mangle: {
66+
properties: {
67+
// Enable property name mangling/minification for private-style properties (starting with _)
68+
regex: /^_/,
69+
},
70+
},
71+
},
72+
6473
lib: {
6574
...libConfig[lib],
6675
name: 'OneSignal',

0 commit comments

Comments
 (0)