Skip to content

Commit 2b66a05

Browse files
authored
Merge pull request #1239 from OneSignal/fg/remove-amp
Remove Amp Code
2 parents bf8e8dc + 1246c82 commit 2b66a05

16 files changed

Lines changed: 140 additions & 542 deletions

.github/workflows/cd.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,3 @@ jobs:
2929
path: 'build/releases'
3030
destination: 'sdk-builds-persistence-onesignal/web-sdk/${{ github.sha }}'
3131
parent: false
32-
- name: '[Deploy] Upload AMP SDK Files to GCS'
33-
uses: 'google-github-actions/upload-cloud-storage@v1'
34-
with:
35-
path: 'build/amp'
36-
destination: 'sdk-builds-persistence-onesignal/web-sdk/${{ github.sha }}'
37-
parent: false

MIGRATION_GUIDE.md

Lines changed: 107 additions & 89 deletions
Large diffs are not rendered by default.

build/amp/amp-helper-frame.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

build/amp/amp-helper-frame.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

build/amp/amp-permission-dialog.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

build/amp/amp-permission-dialog.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,17 +66,17 @@
6666
},
6767
{
6868
"path": "./build/releases/OneSignalSDK.page.es6.js",
69-
"limit": "64 kB",
69+
"limit": "63.5 kB",
7070
"gzip": true
7171
},
7272
{
7373
"path": "./build/releases/OneSignalSDK.sw.js",
74-
"limit": "38 kB",
74+
"limit": "37.5 kB",
7575
"gzip": true
7676
},
7777
{
7878
"path": "./build/releases/OneSignalSDK.page.styles.css",
79-
"limit": "9 kB",
79+
"limit": "8.9 kB",
8080
"gzip": true
8181
}
8282
]

preview/README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@
2424
3. Make sure the common name (e.g: localhost, texas, oregon, etc...) maps to the correct IP in your `/etc/hosts` file
2525
4. Visit [https://localhost:4001?app_id=](https://localhost:4001?app_id=) and insert your app id as a URL query parameter
2626
27-
#### AMP Sandbox
28-
29-
Visit [https://localhost:4001/amp?app_id=](https://localhost:4001/amp?app_id=) and insert your app id as a URL query parameter
30-
3127
### Build Instructions
3228
3329
First: get a shell inside the container: `docker-compose exec onesignal-web-sdk-dev bash`

preview/amp/OneSignalSDK.sw.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

preview/amp/amp-helper-frame.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)