refactor: reduce bundle size via dead code removal and log shortening (#1439)

Author: fadi-george

.cursor/rules/conventions.md

@@ -0,0 +1,32 @@
+---
+description: Conventions for pull request titles and body content
+alwaysApply: true
+---
+
+# Pull Request Conventions
+
+## PR Title
+
+Use semantic/conventional commit prefixes in PR titles:
+
+- `fix:` for bug fixes
+- `feat:` for new features
+- `chore:` for maintenance tasks (deps, CI, tooling)
+- `refactor:` for code restructuring without behavior changes
+- `docs:` for documentation-only changes
+- `test:` for test-only changes
+
+Example: `fix: resolve notification grouping on Android 14`
+
+## PR Body
+
+Follow the repo's PR template at `.github/pull_request_template.md`. Every PR body must include:
+
+1. **One Line Summary** (required)
+2. **Motivation** (required) explaining why the change is being made
+3. **Scope** (recommended) describing what is and isn't affected
+4. **Testing** section with manual and/or unit testing details
+5. **Affected code checklist** with relevant items checked
+6. **Checklist** sections confirmed
+
+Remove the instructional header block (between `<!-- START -->` and `<!-- END -->`) before submitting.

.cursor/rules/pr-conventions.md

@@ -77,12 +77,12 @@
     },
     {
       "path": "./build/releases/OneSignalSDK.page.es6.js",
-      "limit": "43.69 kB",
+      "limit": "41.94 kB",
       "gzip": true
     },
     {
       "path": "./build/releases/OneSignalSDK.sw.js",
-      "limit": "12.701 kB",
+      "limit": "12.272 kB",
       "gzip": true
     },
     {

package.json

@@ -34,11 +34,7 @@ export class CustomEventsOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(
-      `CustomEventsOperationExecutor(operations: ${JSON.stringify(
-        operations,
-      )})`,
-    );
+    Log._debug(`CustomEventOpExec(${JSON.stringify(operations)})`);
 
     // TODO: each trackEvent is sent individually right now; may need to batch in the future
     const operation = operations[0];

src/core/executors/CustomEventOperationExecutor.ts

@@ -40,9 +40,7 @@ export class IdentityOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(
-      `IdentityOperationExecutor(operations: ${JSON.stringify(operations)})`,
-    );
+    Log._debug(`IdentityOpExec(${JSON.stringify(operations)})`);
 
     const invalidOps = operations.filter(
       (op) =>

src/core/executors/IdentityOperationExecutor.ts

@@ -61,9 +61,7 @@ export class LoginUserOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(
-      `LoginUserOperationExecutor(operation: ${JSON.stringify(operations)})`,
-    );
+    Log._debug(`LoginUserOpExec(${JSON.stringify(operations)})`);
     const startingOp = operations[0];
 
     if (startingOp instanceof LoginUserOperation)
@@ -121,13 +119,11 @@ export class LoginUserOperationExecutor implements IOperationExecutor {
       }
 
       case ExecutionResult._FailConflict:
-        Log._debug(`Handling 409 for externalId: ${loginUserOp._externalId}`);
+        Log._debug(`409 conflict: ${loginUserOp._externalId}`);
         return this._createUser(loginUserOp, operations);
 
       case ExecutionResult._FailNoretry:
-        Log._error(
-          `Recovering from SetAlias failure for externalId: ${loginUserOp._externalId}`,
-        );
+        Log._error(`SetAlias failed: ${loginUserOp._externalId}`);
         return this._createUser(loginUserOp, operations);
 
       default:

src/core/executors/LoginUserOperationExecutor.ts

@@ -52,9 +52,7 @@ export class RefreshUserOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(
-      `RefreshUserOperationExecutor(operation: ${JSON.stringify(operations)})`,
-    );
+    Log._debug(`RefreshUserOpExec(${JSON.stringify(operations)})`);
 
     if (operations.some((op) => !(op instanceof RefreshUserOperation)))
       throw new Error(

src/core/executors/RefreshUserOperationExecutor.ts

@@ -53,7 +53,7 @@ export class SubscriptionOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(`SubscriptionOperationExecutor(operations: ${operations})`);
+    Log._debug(`SubOpExec(${operations})`);
 
     const startingOp = operations[0];
     if (startingOp instanceof CreateSubscriptionOperation)

src/core/executors/SubscriptionOperationExecutor.ts

@@ -78,7 +78,7 @@ export class UpdateUserOperationExecutor implements IOperationExecutor {
   }
 
   async _execute(operations: Operation[]): Promise<ExecutionResponse> {
-    Log._debug(`UpdateUserOperationExecutor(operation: ${operations})`);
+    Log._debug(`UpdateUserOpExec(${operations})`);
 
     const { appId, onesignalId, propertiesObject, refreshDeviceMetadata } =
       this._processOperations(operations);

src/core/executors/UpdateUserOperationExecutor.ts

@@ -27,7 +27,7 @@ export class OperationModelStore extends ModelStore<Operation> {
 
   _create(jsonObject?: { name?: string } | null): Operation | null {
     if (jsonObject === null) {
-      Log._error('null jsonObject sent to OperationModelStore.create');
+      Log._error('null jsonObject in OpModelStore.create');
       return null;
     }
 
@@ -96,7 +96,7 @@ export class OperationModelStore extends ModelStore<Operation> {
   } {
     const operationName = object?.name;
     if (!operationName) {
-      Log._error("jsonObject must have 'name' attribute");
+      Log._error("Missing 'name' attribute");
       return false;
     }