Skip to content

Commit 4728ca1

Browse files
authored
Migrate to Vite+ toolchain, fix all lint errors, and remove async from synchronous code (#1445)
1 parent ba9d575 commit 4728ca1

244 files changed

Lines changed: 2093 additions & 4735 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.devcontainer/devcontainer.json

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,38 @@
22
// https://github.com/microsoft/vscode-dev-containers/tree/v0.163.1/containers/docker-existing-docker-compose
33
// If you want to run as a non-root user in the container, see .devcontainer/docker-compose.yml.
44
{
5-
"name": "Existing Docker Compose (Extend)",
5+
"name": "Existing Docker Compose (Extend)",
66

7-
// Update the 'dockerComposeFile' list if you have more compose files or use different names.
8-
// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
9-
"dockerComposeFile": [
10-
"../docker-compose.yml"
11-
],
7+
// Update the 'dockerComposeFile' list if you have more compose files or use different names.
8+
// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
9+
"dockerComposeFile": ["../docker-compose.yml"],
1210

13-
"service": "onesignal-web-sdk-dev",
11+
"service": "onesignal-web-sdk-dev",
1412

15-
// The optional 'workspaceFolder' property is the path VS Code should open by default when
16-
// connected. This is typically a file mount in .devcontainer/docker-compose.yml
17-
"workspaceFolder": "/sdk",
13+
// The optional 'workspaceFolder' property is the path VS Code should open by default when
14+
// connected. This is typically a file mount in .devcontainer/docker-compose.yml
15+
"workspaceFolder": "/sdk",
1816

19-
// Set *default* container specific settings.json values on container create.
20-
"settings": {
21-
"terminal.integrated.shell.linux": null
22-
},
17+
// Set *default* container specific settings.json values on container create.
18+
"settings": {
19+
"terminal.integrated.shell.linux": null
20+
},
2321

24-
// Add the IDs of extensions you want installed when the container is created.
25-
"extensions": []
22+
// Add the IDs of extensions you want installed when the container is created.
23+
"extensions": []
2624

27-
// Use 'forwardPorts' to make a list of ports inside the container available locally.
28-
// "forwardPorts": [],
25+
// Use 'forwardPorts' to make a list of ports inside the container available locally.
26+
// "forwardPorts": [],
2927

30-
// Uncomment the next line if you want start specific services in your Docker Compose config.
31-
// "runServices": [],
28+
// Uncomment the next line if you want start specific services in your Docker Compose config.
29+
// "runServices": [],
3230

33-
// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
34-
// "shutdownAction": "none",
31+
// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
32+
// "shutdownAction": "none",
3533

36-
// Uncomment the next line to run commands after the container is created - for example installing curl.
37-
// "postCreateCommand": "apt-get update && apt-get install -y curl",
34+
// Uncomment the next line to run commands after the container is created - for example installing curl.
35+
// "postCreateCommand": "apt-get update && apt-get install -y curl",
3836

39-
// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
40-
// "remoteUser": "vscode"
37+
// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
38+
// "remoteUser": "vscode"
4139
}

.github/os_probot_metadata.js

Lines changed: 0 additions & 58 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,56 @@
11
# Description
2+
23
## 1 Line Summary
34

45
## Details
56

67
# Systems Affected
7-
- [ ] WebSDK
8-
- [ ] Backend
9-
- [ ] Dashboard
8+
9+
- [ ] WebSDK
10+
- [ ] Backend
11+
- [ ] Dashboard
1012

1113
# Validation
14+
1215
## Tests
16+
1317
### Info
1418

1519
### Checklist
16-
- [ ] All the automated tests pass or I explained why that is not possible
17-
- [ ] I have personally tested this on my machine or explained why that is not possible
18-
- [ ] I have included test coverage for these changes or explained why they are not needed
20+
21+
- [ ] All the automated tests pass or I explained why that is not possible
22+
- [ ] I have personally tested this on my machine or explained why that is not possible
23+
- [ ] I have included test coverage for these changes or explained why they are not needed
1924

2025
**Programming Checklist**
2126
Interfaces:
22-
- [ ] Don't use default export
23-
- [ ] New interfaces are in model files
27+
28+
- [ ] Don't use default export
29+
- [ ] New interfaces are in model files
2430

2531
Functions:
26-
- [ ] Don't use default export
27-
- [ ] All function signatures have return types
28-
- [ ] Helpers should not access any data but rather be given the data to operate on.
32+
33+
- [ ] Don't use default export
34+
- [ ] All function signatures have return types
35+
- [ ] Helpers should not access any data but rather be given the data to operate on.
2936

3037
Typescript:
31-
- [ ] No Typescript warnings
32-
- [ ] Avoid silencing null/undefined warnings with the exclamation point
38+
39+
- [ ] No Typescript warnings
40+
- [ ] Avoid silencing null/undefined warnings with the exclamation point
3341

3442
Other:
35-
- [ ] Iteration: refrain from using `elem of array` syntax. Prefer `forEach` or use `map`
36-
- [ ] Avoid using global OneSignal accessor for `context` if possible. Instead, we can pass it to function/constructor so that we don't call `OneSignal.context`
43+
44+
- [ ] Iteration: refrain from using `elem of array` syntax. Prefer `forEach` or use `map`
45+
- [ ] Avoid using global OneSignal accessor for `context` if possible. Instead, we can pass it to function/constructor so that we don't call `OneSignal.context`
3746

3847
## Screenshots
48+
3949
### Info
4050

4151
### Checklist
42-
- [ ] I have included screenshots/recordings of the intended results or explained why they are not needed
52+
53+
- [ ] I have included screenshots/recordings of the intended results or explained why they are not needed
4354

4455
---
4556

.github/release-drafter.yml

Lines changed: 0 additions & 27 deletions
This file was deleted.

.github/set_response_times.js

Lines changed: 0 additions & 63 deletions
This file was deleted.

.github/workflows/asana-add-comment.yml

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)