Skip to content

Commit 9a90adc

Browse files
authored
Merge pull request #1314 from OneSignal/fg/preview-fix
Fixes Docker volume mounting and webpack-cli
2 parents abb07b5 + 907e3b8 commit 9a90adc

6 files changed

Lines changed: 319 additions & 1594 deletions

File tree

.vscode/launch.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@
55
"name": "Launch Chrome",
66
"request": "launch",
77
"type": "chrome",
8-
"url": "https://localhost:4001",
8+
"url": "https://localhost:4000",
9+
"webRoot": "${workspaceFolder}"
10+
},
11+
{
12+
"name": "Launch Edge",
13+
"request": "launch",
14+
"type": "msedge",
15+
"url": "https://localhost:4000",
916
"webRoot": "${workspaceFolder}"
1017
}
1118
]

docker-compose.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@ services:
55
build: .
66
volumes:
77
- .:/sdk:cached
8+
- /sdk/node_modules
9+
- /sdk/preview/node_modules
810
- ./build/releases:/sdk/build/releases
911
ports:
1012
- published: 4001
1113
target: 4001
12-
- published: 4000
13-
target: 4000
14+
- published: 4002
15+
target: 4002
1416
command: /bin/sh -c "./docker/docker-entry-point.sh"
1517
# Named volumes that are persisted between docker-compose rebuilds.
1618
# If you need to remove these volumes for some reason, run `docker-compose down -v`

0 commit comments

Comments
 (0)