Skip to content

Commit fb06e61

Browse files
authored
Merge pull request #1237 from OneSignal/remove-express_webpack-refs
chore: replace references to `express_webpack` with `preview`
2 parents c5e83a8 + 881eccb commit fb06e61

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

docker/docker-entry-point.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
# Installs dependencies to build SDK
44
npm ci
55

6-
cd express_webpack
6+
cd preview
77

88
# Installs dependencies to run Sandbox for dev env
99
npm ci
1010

1111
# Sandbox cert generation
1212
npm run certs
1313

14-
# Starts express_webpack node server
14+
# Starts preview node server
1515
npm start
1616

1717
# Run the below 2 commands to rebuild the sdk

preview/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
2. Follow the following instructions (also logged in console)
1616
- copy `dev-ssl.crt` from container to host with:
1717
```
18-
docker cp "$(docker-compose ps -q onesignal-web-sdk-dev)":sdk/express_webpack/certs/dev-ssl.crt .
18+
docker cp "$(docker-compose ps -q onesignal-web-sdk-dev)":sdk/preview/certs/dev-ssl.crt .
1919
```
2020
- If you're running the container in a VM, get the cert file onto the VM's host (e.g: use `scp`)
2121
- Add cert to system's trusted store

preview/certs/gen-cert.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
FILE=./certs/dev-ssl.crt
22
if test -f "$FILE"; then
3-
echo "express_webpack: dev-ssl.crt already exists."
4-
echo "express_webpack: skipping SSL cert generation."
3+
echo "preview: dev-ssl.crt already exists."
4+
echo "preview: skipping SSL cert generation."
55
else
6-
echo "express_webpack:\n------ generating new SSL certs ------"
7-
echo "copy dev-ssl.crt from container to host with:\n> docker cp <containerId>:sdk/express_webpack/certs/dev-ssl.crt ."
6+
echo "preview:\n------ generating new SSL certs ------"
7+
echo "copy dev-ssl.crt from container to host with:\n> docker cp <containerId>:sdk/preview/certs/dev-ssl.crt ."
88
echo "macOS - add cert to keychain:\n> sudo security add-trusted-cert -d -r trustRoot -k /Library/Keychains/System.keychain ~/dev-ssl.crt\n"
99
echo "Windows - add cert to cert store:\n> Import-Certificate -FilePath dev-ssl.crt -CertStoreLocation cert:\CurrentUser\Root"
1010
echo "restart browser\n--------------------------------------"

preview/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

preview/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "express_webpack",
2+
"name": "preview",
33
"version": "1.0.0",
44
"description": "",
55
"main": "index.js",

preview/server.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ app.get('/push/onesignal/:file', (req, res) => {
4343
https
4444
.createServer(options, app)
4545
.listen(4001, () =>
46-
console.info('express_webpack: listening on port 4001 (https)'),
46+
console.info('preview: listening on port 4001 (https)'),
4747
);
4848

4949
// http
5050
app.listen(4000, () =>
51-
console.info('express_webpack: listening on port 4000 (http)'),
51+
console.info('preview: listening on port 4000 (http)'),
5252
);

0 commit comments

Comments
 (0)