Skip to content

chore: replace references to express_webpack with preview#1237

Merged
sherwinski merged 1 commit intomainfrom
remove-express_webpack-refs
Mar 18, 2025
Merged

chore: replace references to express_webpack with preview#1237
sherwinski merged 1 commit intomainfrom
remove-express_webpack-refs

Conversation

@sherwinski
Copy link
Copy Markdown
Contributor

@sherwinski sherwinski commented Mar 18, 2025

Description

1 Line Summary

Removes some left-over references to express_webpack, which were removed in #1231 and #1232, with preview.

Details

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@sherwinski sherwinski requested a review from fadi-george March 18, 2025 15:36
@sherwinski sherwinski merged commit fb06e61 into main Mar 18, 2025
4 checks passed
@sherwinski sherwinski deleted the remove-express_webpack-refs branch March 18, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants