Analyze build files for unused code#1346
Closed
fadi-george wants to merge 1 commit intomainfrom
Closed
Conversation
Co-authored-by: fadi <fadi@onesignal.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Adds a detailed analysis of OneSignal SDK build files, identifying potential unused code and optimization opportunities.
Details
This PR introduces
build/build.md, a new document containing a comprehensive analysis of theDev-OneSignalSDK.page.jsandDev-OneSignalSDK.sw.jsbuild outputs. The analysis identifies various categories of potentially unused or redundant code, such as:DebugNamespace,Log2)The document also provides recommendations for code reduction and estimates potential bundle size savings, serving as a guide for future optimization efforts.
Systems Affected
Validation
Tests
Info
This PR only adds a documentation file (
build/build.md) and does not modify any functional code. Therefore, no automated tests are applicable or required. The content of the markdown file is the primary output.Checklist
build.mdfile content is as expected.Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Not applicable as this PR adds a markdown documentation file. The file itself is the output.
Checklist
Related Tickets
N/A
This change is