SDK-2897 Fix Subscription Change Event Firing Twice

[fadi-george]

Description

1 Line Summary

Fix event emitter firing twice and update login flow to not need setting push id/token separately from event helper.

Details

• Update getAppState to return undefined instead of null for token and id. This will prevent the subscription change event from firing twice
• Remove calls like setPushId or setPushToken since checkAndTriggerSubscriptionChanged should app state with new push id and token
• Updates refresh user executor to use OneSignal.coreDirector.getPushSubscriptionModel since that can get a push model by token. If you were to call login before accepting push notifications this would have a first /users call with external id but no subscriptions and a second /users call with external & 1 push sub. If we didnt use getPushSubscriptionModel then refresh user op will call _subscriptionsModelStore.replaceAll with an empty array.

Pre web-refactor:

Current:

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is