Wait for user to provide consent before executing operations#1363
Merged
fadi-george merged 5 commits intomainfrom Aug 29, 2025
Merged
Wait for user to provide consent before executing operations#1363fadi-george merged 5 commits intomainfrom
fadi-george merged 5 commits intomainfrom
Conversation
cd72915 to
30cb40c
Compare
2102a8f to
42ff7f1
Compare
42ff7f1 to
9bdc258
Compare
f87b901 to
596e675
Compare
596e675 to
ecab606
Compare
sherwinski
approved these changes
Aug 29, 2025
| "dependencies": { | ||
| "idb": "^8.0.3", | ||
| "jsonp": "github:OneSignal/jsonp#onesignal", | ||
| "uuid": "^11.1.0" |
Contributor
There was a problem hiding this comment.
just double checking that we don't use this anywhere?
Contributor
There was a problem hiding this comment.
I assume we replaced it with crypto.randomUUID()?
Contributor
Author
There was a problem hiding this comment.
Yes we use crypto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Addresses: https://app.asana.com/1/780103692902078/project/1198177413178126/task/1211152956512052?focus=true
Details
Current erorr:

Changes:
isConsentRequiredButNotGivenhelper to check against consent required and consent given flags.OneSignal._consentGivenwhich is loaded in init . This is needed since we dont we to add delay for the login call and don want to make actions like addTags async.addTag,addTags,addEmail,addSms, etc.requiresUserPrivacyConsenttogetConsentRequiredcall.Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is