More Size Reduction via _ Prefix

[fadi-george]

Description

1 Line Summary

• add more _ prefix for to class methods

Details

• The vite config settings currently use terser with a mangleProps that uses _ to denote which constants/properties to minify/mangle for helping with reducing bundle size

Main:

  build/releases/OneSignalSDK.page.js
  Size limit: 450 B
  Size:       450 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 52.18 kB
  Size:       52.18 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 14.54 kB
  Size:       14.54 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped

Branch:

  build/releases/OneSignalSDK.page.js
  Size limit: 450 B
  Size:       450 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 51.85 kB
  Size:       51.85 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 13.93 kB
  Size:       13.93 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

[sherwinski]

what's the reason for removing this?

[fadi-george]

Its very legacy code and safari can show boxshadows