Return undefined for local onesignal id#1370
Merged
fadi-george merged 2 commits intomainfrom Sep 2, 2025
Merged
Conversation
37f0a90 to
4cb4f6b
Compare
jkasten2
reviewed
Sep 2, 2025
Comment on lines
-58
to
+60
| get onesignalId(): string { | ||
| return OneSignal.coreDirector.getIdentityModel().onesignalId; | ||
| get onesignalId(): string | undefined { | ||
| const onesignalId = OneSignal._coreDirector._getIdentityModel().onesignalId; | ||
| return IDManager._isLocalId(onesignalId) ? undefined : onesignalId; |
Member
There was a problem hiding this comment.
nit, on splitting up commits. A logic change like this mixed in with a refactor (a rename in this case) makes this hard to spot.
jkasten2
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is