SDK-2923 Fix Bell Inactive / Active State#1373
Closed
fadi-george wants to merge 2 commits intomainfrom
Closed
Conversation
fadi-george
changed the title
fadi-george
requested review from
jkasten2 and
sherwinski
and removed request for
sherwinski
fadi-george
force-pushed
the
fadi/sdk-2923-subscription-bell-and-popup-are-transparent-in-opened-state-2
branch
3 times, most recently
from
9a43bc9 to
637ef7e
Compare
fadi-george
force-pushed
the
fadi/sdk-2923-subscription-bell-and-popup-are-transparent-in-opened-state-2
branch
from
637ef7e to
4a5f87f
Compare
sherwinski
reviewed
Sep 5, 2025
Comment on lines
+67
to
+90
| _onHovering() { | ||
| if ( | ||
| LimitStore.isEmpty(this.events.mouse) || | ||
| LimitStore.getLast(this.events.mouse) === 'out' | ||
| LimitStore.isEmpty(this._events.mouse) || | ||
| LimitStore.getLast(this._events.mouse) === 'out' | ||
| ) { | ||
| OneSignalEvent.trigger(Bell.EVENTS.HOVERING); | ||
| OneSignalEvent.trigger('notifyButtonHovering'); | ||
| } | ||
| LimitStore.put(this.events.mouse, 'over'); | ||
| LimitStore.put(this._events.mouse, 'over'); | ||
| } | ||
|
|
||
| onHovered() { | ||
| LimitStore.put(this.events.mouse, 'out'); | ||
| OneSignalEvent.trigger(Bell.EVENTS.HOVERED); | ||
| _onHovered() { | ||
| LimitStore.put(this._events.mouse, 'out'); | ||
| OneSignalEvent.trigger('notifyButtonHover'); | ||
| } | ||
|
|
||
| onTap() { | ||
| this.pulse(); | ||
| this.activate(); | ||
| this.bell.badge.activate(); | ||
| _onTap() { | ||
| this._pulse(); | ||
| this._activate(); | ||
| this._bell._badge._activate(); | ||
| } | ||
|
|
||
| onEndTap() { | ||
| this.inactivate(); | ||
| this.bell.badge.inactivate(); | ||
| _onEndTap() { | ||
| this._inactivate(); | ||
| this._bell._badge._inactivate(); |
Contributor
There was a problem hiding this comment.
Including changes like these in the same commit make it difficult to parse out the parts that actually affect Bell behavior. I generally recommend keeping any refactoring changes to their own separate commits.
Comment on lines
+14
to
+20
| StateChanged: 'notify0', | ||
| LauncherClick: 'notify1', | ||
| BellClick: 'notify2', | ||
| SubscribeClick: 'notify3', | ||
| UnsubscribeClick: 'notify4', | ||
| Hovering: 'notify5', | ||
| Hovered: 'notify6', |
Contributor
There was a problem hiding this comment.
I'm not sure I understand the purpose of this change? Is it meant to help with bundle size by shortening the values?
Contributor
Author
|
Ill remake the pr with simpler changes |
fadi-george
deleted the
fadi/sdk-2923-subscription-bell-and-popup-are-transparent-in-opened-state-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Before:
Screen.Recording.2025-09-03.at.1.27.02.PM.mov
After:
Screen.Recording.2025-09-03.at.1.27.14.PM.mov
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is