Skip to content

add create release notes workflow#1387

Merged
fadi-george merged 2 commits intomainfrom
fadi/sdk-2939-automate-generating-new-release-on-turbine-merge
Sep 16, 2025
Merged

add create release notes workflow#1387
fadi-george merged 2 commits intomainfrom
fadi/sdk-2939-automate-generating-new-release-on-turbine-merge

Conversation

@fadi-george
Copy link
Copy Markdown
Contributor

@fadi-george fadi-george commented Sep 16, 2025

Description

1 Line Summary

  • adds new create release notes pr

Details

  • workflow checks the current sdk version and checks if the tag exists
  • if tag doesnt exist, workflow will proceed to create a new release and tag

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The file name create-release-notes.yml could be a bit better, the workflow creates a release on Github, rather than creating the notes itself. What do you think about the name create-release-on-github.yml instead?

@fadi-george
Copy link
Copy Markdown
Contributor Author

create-release-on-github

Sure

@fadi-george fadi-george merged commit f5146e6 into main Sep 16, 2025
3 checks passed
@fadi-george fadi-george deleted the fadi/sdk-2939-automate-generating-new-release-on-turbine-merge branch September 16, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants