refactor: more size reduction

[fadi-george]

Description

1 Line Summary

More size reduction via _ prefix.

Details

• Update non api.json spec class properties to have an underscore prefix. This to allow vite to mangle the properties name to smaller strings to reduce bundle size.

// Old
  build/releases/OneSignalSDK.page.js
  Package size is 1 B less than limit
  Size limit: 421 B
  Size:       420 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 50.29 kB
  Size:       50.29 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 13.62 kB
  Size:       13.62 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped
  
// New
  build/releases/OneSignalSDK.page.js
  Package size is 1 B less than limit
  Size limit: 421 B
  Size:       420 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 49.63 kB
  Size:       49.63 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 13.62 kB
  Size:       13.62 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped
  

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

[jkasten2]

Code changes look good.

Did this change only effect the size of OneSignalSDK.page.es6.js this time?, I only see this size updated in package.json.

[fadi-george]

Code changes look good.

Did this change only effect the size of OneSignalSDK.page.es6.js this time?, I only see this size updated in package.json.

Yeah 50.29 -> 49.63