chore: more size reduction

[fadi-george]

Description

1 Line Summary

• more size reduction

Details

• more underscore prefixing renaming
• also break up subscription helper

// old
  build/releases/OneSignalSDK.page.js
  Size limit: 420 B
  Size:       420 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 47.88 kB
  Size:       47.88 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 13.62 kB
  Size:       13.62 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped

// new
  build/releases/OneSignalSDK.page.js
  Size limit: 420 B
  Size:       420 B gzipped
  
  build/releases/OneSignalSDK.page.es6.js
  Size limit: 47.59 kB
  Size:       47.59 kB gzipped
  
  build/releases/OneSignalSDK.sw.js
  Size limit: 13.62 kB
  Size:       13.62 kB gzipped
  
  build/releases/OneSignalSDK.page.styles.css
  Size limit: 8.81 kB
  Size:       8.8 kB  gzipped

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

---

---

This change is 

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1211568577330428

[sherwinski]

suggestion: consider pulling the macro into a task in package.json that can be run with the linter and formatter

[sherwinski]

nit: maybe this can be compressed into

Suggested change

	return new PropertiesObject({
	return new PropertiesObject(
	allowedKeys.includes(propertyKey)
	? { ...properties, [propertyKey]: operation.value }
	: { ...properties }
	);

[fadi-george]

return new PropertiesObject

@sherwinski not all renames will be beneficial since gzip fill find common patterns to reuse so some cases a prefix rename will increase the size.