chore: more size reduction#1401
Merged
fadi-george merged 9 commits intomainfrom Oct 24, 2025
Merged
Conversation
fadi-george
commented
Oct 17, 2025
| this.path = path.trim(); | ||
| } | ||
|
|
||
| getQueryString(): string | null { |
sherwinski
requested changes
Oct 23, 2025
| @@ -0,0 +1,47 @@ | |||
| /* | |||
| LimitStore.put('colorado', 'rocky'); | |||
Contributor
There was a problem hiding this comment.
Rename to use new function name
| store[key] = [null, null]; | ||
| } | ||
| store[key].push(value); | ||
| if (store[key].length == LIMIT + 1) { |
Contributor
There was a problem hiding this comment.
consider using strict equality
Suggested change
| if (store[key].length == LIMIT + 1) { | |
| if (store[key].length === LIMIT + 1) { |
| declare const self: ServiceWorkerGlobalScope; | ||
| self.OneSignalWorker = OneSignalServiceWorker; | ||
| // The run() is already called in ServiceWorker.ts, but importing it ensures it's not tree-shaken | ||
| void run; |
Contributor
There was a problem hiding this comment.
I would need confirmation that this actually works: e.g. does it actually make it to the final bundle? Even then, this approach seems confusing and potentially fragile.
I'm suspicious that it's not needed especially because run is already invoked at the top-level here.
My suggestion would be to either move that line here
import { run } from '../sw/serviceWorker/ServiceWorker';
run();or import the entire file (although the bundle size may take a hit)
import '../sw/serviceWorker/ServiceWorker';
// The run() is already called in ServiceWorker.ts, but importing it ensures it's not tree-shaken
void run;
Contributor
Author
There was a problem hiding this comment.
Both work but for now ive moved run called to worker.ts
sherwinski
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is