refactor: reduce bundle size via dead code removal and log shortening#1439
Merged
fadi-george merged 7 commits intomainfrom Mar 9, 2026
Merged
refactor: reduce bundle size via dead code removal and log shortening#1439fadi-george merged 7 commits intomainfrom
fadi-george merged 7 commits intomainfrom
Conversation
abdulraqeeb33
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Reduce SDK bundle size by removing unused code, simplifying helpers, shortening debug messages, and removing legacy v16 beta worker fallback.
Details
Series of refactors targeting gzipped bundle size:
context/helpers.tsdeleted,dom.tssimplified)Size Limit Changes
OneSignalSDK.page.es6.jsOneSignalSDK.sw.jsNet reduction of ~2.14 kB gzipped across the two main bundles.
Systems Affected
Validation
Tests
Info
Updated existing unit tests to match shortened debug messages. No behavioral changes, only refactoring.
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
N/A, no UI changes.
Checklist
Related Tickets
Made with Cursor
This change is