Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 24 additions & 26 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,38 @@
// https://github.com/microsoft/vscode-dev-containers/tree/v0.163.1/containers/docker-existing-docker-compose
// If you want to run as a non-root user in the container, see .devcontainer/docker-compose.yml.
{
"name": "Existing Docker Compose (Extend)",
"name": "Existing Docker Compose (Extend)",

// Update the 'dockerComposeFile' list if you have more compose files or use different names.
// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
"dockerComposeFile": [
"../docker-compose.yml"
],
// Update the 'dockerComposeFile' list if you have more compose files or use different names.
// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
"dockerComposeFile": ["../docker-compose.yml"],

"service": "onesignal-web-sdk-dev",
"service": "onesignal-web-sdk-dev",

// The optional 'workspaceFolder' property is the path VS Code should open by default when
// connected. This is typically a file mount in .devcontainer/docker-compose.yml
"workspaceFolder": "/sdk",
// The optional 'workspaceFolder' property is the path VS Code should open by default when
// connected. This is typically a file mount in .devcontainer/docker-compose.yml
"workspaceFolder": "/sdk",

// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.shell.linux": null
},
// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.shell.linux": null
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": []
// Add the IDs of extensions you want installed when the container is created.
"extensions": []

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Uncomment the next line if you want start specific services in your Docker Compose config.
// "runServices": [],
// Uncomment the next line if you want start specific services in your Docker Compose config.
// "runServices": [],

// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
// "shutdownAction": "none",
// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
// "shutdownAction": "none",

// Uncomment the next line to run commands after the container is created - for example installing curl.
// "postCreateCommand": "apt-get update && apt-get install -y curl",
// Uncomment the next line to run commands after the container is created - for example installing curl.
// "postCreateCommand": "apt-get update && apt-get install -y curl",

// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
// "remoteUser": "vscode"
// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
// "remoteUser": "vscode"
}
58 changes: 0 additions & 58 deletions .github/os_probot_metadata.js

This file was deleted.

43 changes: 27 additions & 16 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,56 @@
# Description

## 1 Line Summary

## Details

# Systems Affected
- [ ] WebSDK
- [ ] Backend
- [ ] Dashboard

- [ ] WebSDK
- [ ] Backend
- [ ] Dashboard

# Validation

## Tests

### Info

### Checklist
- [ ] All the automated tests pass or I explained why that is not possible
- [ ] I have personally tested this on my machine or explained why that is not possible
- [ ] I have included test coverage for these changes or explained why they are not needed

- [ ] All the automated tests pass or I explained why that is not possible
- [ ] I have personally tested this on my machine or explained why that is not possible
- [ ] I have included test coverage for these changes or explained why they are not needed

**Programming Checklist**
Interfaces:
- [ ] Don't use default export
- [ ] New interfaces are in model files

- [ ] Don't use default export
- [ ] New interfaces are in model files

Functions:
- [ ] Don't use default export
- [ ] All function signatures have return types
- [ ] Helpers should not access any data but rather be given the data to operate on.

- [ ] Don't use default export
- [ ] All function signatures have return types
- [ ] Helpers should not access any data but rather be given the data to operate on.

Typescript:
- [ ] No Typescript warnings
- [ ] Avoid silencing null/undefined warnings with the exclamation point

- [ ] No Typescript warnings
- [ ] Avoid silencing null/undefined warnings with the exclamation point

Other:
- [ ] Iteration: refrain from using `elem of array` syntax. Prefer `forEach` or use `map`
- [ ] Avoid using global OneSignal accessor for `context` if possible. Instead, we can pass it to function/constructor so that we don't call `OneSignal.context`

- [ ] Iteration: refrain from using `elem of array` syntax. Prefer `forEach` or use `map`
- [ ] Avoid using global OneSignal accessor for `context` if possible. Instead, we can pass it to function/constructor so that we don't call `OneSignal.context`

## Screenshots

### Info

### Checklist
- [ ] I have included screenshots/recordings of the intended results or explained why they are not needed

- [ ] I have included screenshots/recordings of the intended results or explained why they are not needed

---

Expand Down
27 changes: 0 additions & 27 deletions .github/release-drafter.yml

This file was deleted.

63 changes: 0 additions & 63 deletions .github/set_response_times.js

This file was deleted.

47 changes: 0 additions & 47 deletions .github/workflows/asana-add-comment.yml

This file was deleted.

Loading
Loading