chore(devdeps): pin vite-plus to 0.1.13 to fix broken native binding#1449
chore(devdeps): pin vite-plus to 0.1.13 to fix broken native binding#1449sherwinski merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
LGTM — straightforward dev-dependency pin to restore test runner functionality.
Extended reasoning...
Overview
This PR touches package.json, pnpm-lock.yaml, and one test file (detect.test.ts). The changes pin vite-plus and its associated pnpm overrides from latest to 0.1.13, add explicit vite/vitest devDependency aliases so third-party plugins can resolve peer deps, and add missing beforeEach/afterEach imports in the test file.
Security Risks
No security-sensitive code is touched. All changes are confined to dev dependencies and the test toolchain — nothing here reaches production bundles. The incidental transitive bumps in the lockfile (axios, graphql, undici, proxy-from-env) are all dev/test-only packages.
Level of Scrutiny
Low. This is a targeted hotfix to unblock the test suite after an upstream package shipped a broken native binding. The root cause is clearly documented, the fix is minimal and reversible (pinning to a known-good version), and no application logic is changed.
Other Factors
The detect.test.ts change is a trivially correct import fix — beforeEach/afterEach were used but not imported. No logic changes. The lockfile regeneration is consistent with the package.json changes. No outstanding reviewer comments.
c0c9889 to
3cb9dd0
Compare
Description
1 Line Summary
Pin vite-plus to 0.1.13 to fix a broken native binding in 0.1.14 that prevents tests from running.
Details
vite-plus@0.1.14ships JS code in@voidzero-dev/vite-plus-corethat callsgetOrder()on the Rolldown native binding (BindingCallableBuiltinPlugin), but the companion native binary (@voidzero-dev/vite-plus-darwin-arm64@0.1.14) doesn't expose that method, causing aTypeError: callablePlugin.getOrder is not a functionstartup crash before any tests run.Changes:
vite-plusand its pnpm overrides fromlatestto0.1.13(last working version)viteandvitestdevDependencies aliased to the vite-plus packages so third-party plugins (vite-plugin-mkcert,@vitest/coverage-v8) can resolve their peer dependencies — the pnpm overrides alone don't install them since nothing declaresvite/vitestas a regular dependencybeforeEach/afterEachimports indetect.test.tsSystems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
N/A — dependency and import-only changes, no UI impact.
Checklist
Related Tickets