Skip to content

Commit 24f8c0a

Browse files
authored
fix: warning about OSMacros.h in header (#1642)
* mark OSMacros.h header private to avoid warning - Changed OSMacros.h visibility from Public to Private so the header won't be included in the public Headers folder during the build process - fix warning saying: "umbrella header for module 'OneSignalCore' does not include header 'OSMacros.h'" * use conventional quoted imports for private headers Conventionally correct: Quoted imports (#import "OSMacros.h") are the standard pattern for private/internal headers, now that the OSMacros has been marked from public to private
1 parent 1c97103 commit 24f8c0a

42 files changed

Lines changed: 42 additions & 42 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@
491491
DE7D18C627038249002D3A5D /* OneSignalOutcomes.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D188027037F43002D3A5D /* OneSignalOutcomes.framework */; };
492492
DE7D18CD270385D0002D3A5D /* OSOutcomesRequests.m in Sources */ = {isa = PBXBuildFile; fileRef = DE7D18CB270385D0002D3A5D /* OSOutcomesRequests.m */; };
493493
DE7D18CF270385E0002D3A5D /* OSOutcomesRequests.h in Headers */ = {isa = PBXBuildFile; fileRef = DE7D18CE270385E0002D3A5D /* OSOutcomesRequests.h */; };
494-
DE7D18D1270389E1002D3A5D /* OSMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AE28B8725B8ADF400529100 /* OSMacros.h */; settings = {ATTRIBUTES = (Public, ); }; };
494+
DE7D18D1270389E1002D3A5D /* OSMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AE28B8725B8ADF400529100 /* OSMacros.h */; settings = {ATTRIBUTES = (Private, ); }; };
495495
DE7D18D22703ADE0002D3A5D /* OneSignalOutcomes.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DE7D188027037F43002D3A5D /* OneSignalOutcomes.framework */; };
496496
DE7D18D62703B103002D3A5D /* OSInAppMessageOutcome.m in Sources */ = {isa = PBXBuildFile; fileRef = 7A880F2A23FB45FB0081F5E8 /* OSInAppMessageOutcome.m */; };
497497
DE7D18D72703B111002D3A5D /* OSInAppMessageOutcome.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A880F2923FB45CE0081F5E8 /* OSInAppMessageOutcome.h */; settings = {ATTRIBUTES = (Public, ); }; };

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalAttachmentHandler.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ of this software and associated documentation files (the "Software"), to deal
2828
#import <Foundation/Foundation.h>
2929
#import "OneSignalAttachmentHandler.h"
3030
#import "OneSignalNotificationCategoryController.h"
31-
#import <OneSignalCore/OSMacros.h>
31+
#import "OSMacros.h"
3232

3333
@interface DirectDownloadDelegate : NSObject <NSURLSessionDataDelegate> {
3434
NSError* error;

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalExtensionRequests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ of this software and associated documentation files (the "Software"), to deal
2727

2828
#import <Foundation/Foundation.h>
2929
#import "OneSignalExtensionRequests.h"
30-
#import <OneSignalCore/OSMacros.h>
30+
#import "OSMacros.h"
3131

3232
@implementation OSRequestReceiveReceipts
3333

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalNotificationServiceExtensionHandler.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727

2828
#import <OneSignalCore/OneSignalCore.h>
29-
#import <OneSignalCore/OSMacros.h>
29+
#import "OSMacros.h"
3030
#import <OneSignalOutcomes/OneSignalOutcomes.h>
3131
#import "OneSignalNotificationServiceExtensionHandler.h"
3232
#import "OneSignalExtensionBadgeHandler.h"

iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalReceiveReceiptsController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#import <Foundation/Foundation.h>
2929
#import "OneSignalReceiveReceiptsController.h"
3030
#import <OneSignalCore/OneSignalCore.h>
31-
#import <OneSignalCore/OSMacros.h>
31+
#import "OSMacros.h"
3232
#import "OneSignalExtensionRequests.h"
3333

3434
@implementation OneSignalReceiveReceiptsController

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSDynamicTriggerController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#import "OneSignalCommonDefines.h"
3131
#import "OSMessagingController.h"
3232
#import <OneSignalOutcomes/OneSignalOutcomes.h>
33-
#import <OneSignalCore/OSMacros.h>
33+
#import "OSMacros.h"
3434
#import "OSSessionManager.h"
3535

3636
@interface OSDynamicTriggerController ()

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSInAppMessageController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
#import "OSInAppMessageController.h"
2929
#import <OneSignalCore/OneSignalCore.h>
30-
#import <OneSignalCore/OSMacros.h>
30+
#import "OSMacros.h"
3131
#import <OneSignalUser/OneSignalUser.h>
3232
#import "OSInAppMessagingDefines.h"
3333
#import "OSInAppMessagingRequests.h"

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSInAppMessageMigrationController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ of this software and associated documentation files (the "Software"), to deal
2828
#import "OSInAppMessageMigrationController.h"
2929
#import "OSInAppMessagingDefines.h"
3030
#import "OSInAppMessageInternal.h"
31-
#import <OneSignalCore/OSMacros.h>
31+
#import "OSMacros.h"
3232

3333
@implementation OSInAppMessageMigrationController
3434

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#import "UIApplication+OneSignal.h"
3030
#import "NSDateFormatter+OneSignal.h"
3131
#import <OneSignalCore/OneSignalCore.h>
32-
#import <OneSignalCore/OSMacros.h>
32+
#import "OSMacros.h"
3333
#import "OSInAppMessageClickResult.h"
3434
#import "OSInAppMessageClickEvent.h"
3535
#import "OSInAppMessageController.h"

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSTriggerController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
#import "OSTriggerController.h"
2929
#import "OSInAppMessagingDefines.h"
30-
#import <OneSignalCore/OSMacros.h>
30+
#import "OSMacros.h"
3131

3232
@interface OSTriggerController ()
3333
@property (strong, nonatomic, nonnull) NSMutableDictionary<NSString *, id> *triggers;

0 commit comments

Comments
 (0)