Skip to content

Commit 898cde1

Browse files
committed
build: declare OneSignalOSCore dep for Extension/Notifications/Outcomes
Those subspecs / SPM wrappers ship binaries that now link OneSignalOSCore.framework. Without the declaration, NSE-only integrations via CocoaPods or SPM wouldn't embed it and dyld would fail to load the NSE binary on the first push.
1 parent 597799c commit 898cde1

3 files changed

Lines changed: 9 additions & 0 deletions

File tree

OneSignal.podspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,20 @@ Pod::Spec.new do |s|
2222

2323
s.subspec 'OneSignalOutcomes' do |ss|
2424
ss.dependency 'OneSignal/OneSignalCore'
25+
ss.dependency 'OneSignal/OneSignalOSCore'
2526
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Outcomes/OneSignalOutcomes.xcframework'
2627
end
2728

2829
s.subspec 'OneSignalExtension' do |ss|
2930
ss.dependency 'OneSignal/OneSignalCore'
31+
ss.dependency 'OneSignal/OneSignalOSCore'
3032
ss.dependency 'OneSignal/OneSignalOutcomes'
3133
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Extension/OneSignalExtension.xcframework'
3234
end
3335

3436
s.subspec 'OneSignalNotifications' do |ss|
3537
ss.dependency 'OneSignal/OneSignalCore'
38+
ss.dependency 'OneSignal/OneSignalOSCore'
3639
ss.dependency 'OneSignal/OneSignalOutcomes'
3740
ss.dependency 'OneSignal/OneSignalExtension'
3841
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Notifications/OneSignalNotifications.xcframework'

OneSignalXCFramework.podspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,20 @@ Pod::Spec.new do |s|
2222

2323
s.subspec 'OneSignalOutcomes' do |ss|
2424
ss.dependency 'OneSignalXCFramework/OneSignalCore'
25+
ss.dependency 'OneSignalXCFramework/OneSignalOSCore'
2526
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Outcomes/OneSignalOutcomes.xcframework'
2627
end
2728

2829
s.subspec 'OneSignalExtension' do |ss|
2930
ss.dependency 'OneSignalXCFramework/OneSignalCore'
31+
ss.dependency 'OneSignalXCFramework/OneSignalOSCore'
3032
ss.dependency 'OneSignalXCFramework/OneSignalOutcomes'
3133
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Extension/OneSignalExtension.xcframework'
3234
end
3335

3436
s.subspec 'OneSignalNotifications' do |ss|
3537
ss.dependency 'OneSignalXCFramework/OneSignalCore'
38+
ss.dependency 'OneSignalXCFramework/OneSignalOSCore'
3639
ss.dependency 'OneSignalXCFramework/OneSignalOutcomes'
3740
ss.dependency 'OneSignalXCFramework/OneSignalExtension'
3841
ss.vendored_frameworks = 'iOS_SDK/OneSignalSDK/OneSignal_Notifications/OneSignalNotifications.xcframework'

Package.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ let package = Package(
7575
"OneSignalNotifications",
7676
"OneSignalExtension",
7777
"OneSignalOutcomes",
78+
"OneSignalOSCore",
7879
"OneSignalCore"
7980
],
8081
path: "OneSignalNotificationsWrapper"
@@ -84,6 +85,7 @@ let package = Package(
8485
dependencies: [
8586
"OneSignalExtension",
8687
"OneSignalOutcomes",
88+
"OneSignalOSCore",
8789
"OneSignalCore"
8890
],
8991
path: "OneSignalExtensionWrapper"
@@ -92,6 +94,7 @@ let package = Package(
9294
name: "OneSignalOutcomesWrapper",
9395
dependencies: [
9496
"OneSignalOutcomes",
97+
"OneSignalOSCore",
9598
"OneSignalCore"
9699
],
97100
path: "OneSignalOutcomesWrapper"

0 commit comments

Comments
 (0)