refactor: [SDK-4911] rebuild OperationRepo unmatched delta queue on flush - #1693
Merged
Conversation
Rebuilding the unmatched list avoids for-in + remove(at:) on the same array, which could crash or skip deltas. Co-Authored-By: Cursor <cursoragent@cursor.com>
nan-li
force-pushed
the
nan/fix-flush-delta-queue-iteration
branch
from
July 27, 2026 15:46
13d214f to
29ce8ad
Compare
nan-li
changed the title
Contributor
Author
|
Added tests |
18 tasks
nan-li
changed the title
Co-Authored-By: Cursor <cursoragent@cursor.com>
nan-li
force-pushed
the
nan/fix-flush-delta-queue-iteration
branch
from
July 30, 2026 16:32
130805d to
e2eb189
Compare
Merged
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSOperationRepo.flushDeltaQueueto rebuilddeltaQueueas the list of unmatched deltas instead of removing matched entries while iterating.for-in+remove(at:)on the same array (SwiftArrayvalue semantics make the old loop safe, not undefined behavior).Test plan
OSOperationRepoFlushTests: matched deltas dispatch and clear the repo queue; unmatched stay queued in order.UserConcurrencyTests.testOperationRepoFlushingConcurrencystill relevant (Full plan); it does not assert this routing behavior.