Skip to content

refactor: [SDK-4911] rebuild OperationRepo unmatched delta queue on flush #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 2 commits into from
Jul 31, 2026
Merged

refactor: [SDK-4911] rebuild OperationRepo unmatched delta queue on flush #1693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ce8ad
fix: stop mutating deltaQueue during flush iteration
nan-li Jul 27, 2026
e2eb189
test: cover OperationRepo flush matched/unmatched delta routing
nan-li Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSOperationRepo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,16 @@ public class OSOperationRepo: NSObject {
OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSOperationRepo flushDeltaQueue in background: \(inBackground) with queue: \(self.deltaQueue)")
}

var index = 0
var unmatched: [OSDelta] = []
for delta in self.deltaQueue {
if let executor = self.deltasToExecutorMap[delta.name] {
executor.enqueueDelta(delta)
self.deltaQueue.remove(at: index)
} else {
// keep in queue if no executor matches, we may not have the executor available yet
index += 1
// Keep if no executor matches yet (module may not have started).
unmatched.append(delta)
}
}
self.deltaQueue = unmatched

// Persist the deltas (including removed deltas) to storage after they are divvy'd up to executors.
OneSignalUserDefaults.initShared().saveCodeableData(forKey: OS_OPERATION_REPO_DELTA_QUEUE_KEY, withValue: self.deltaQueue)
Expand Down
Loading