Skip to content

Commit 050baa5

Browse files
committed
chore(release): bump wrapper version to 5.4.4
1 parent c2fc48f commit 050baa5

6 files changed

Lines changed: 31 additions & 5 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,21 @@ jobs:
152152
# Update package.json version
153153
npm pkg set version="$NEW_VERSION"
154154
155+
# Update the wrapper version literal reported to OneSignal's backend.
156+
# Format is MMmmpp (zero-padded major/minor/patch); strip any pre-release suffix.
157+
CORE_VERSION=${NEW_VERSION%%-*}
158+
CORE_VERSION=${CORE_VERSION%%+*}
159+
IFS='.' read -r MAJOR MINOR PATCH <<< "$CORE_VERSION"
160+
PADDED_VERSION=$(printf "%02d%02d%02d" "$MAJOR" "$MINOR" "$PATCH")
161+
162+
sed -i '' -E "s/(OneSignalWrapper\.setSdkVersion\(\")[0-9]+(\"\))/\1${PADDED_VERSION}\2/" \
163+
android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java
164+
echo "✓ Updated RNOneSignal.java wrapper version to ${PADDED_VERSION}"
165+
166+
sed -i '' -E "s/(OneSignalWrapper\.sdkVersion = @\")[0-9]+(\";)/\1${PADDED_VERSION}\2/" \
167+
ios/RCTOneSignal/RCTOneSignal.mm
168+
echo "✓ Updated RCTOneSignal.mm wrapper version to ${PADDED_VERSION}"
169+
155170
# Only commit if there are changes
156171
git add -A
157172
git diff --staged --quiet && exit 0

.github/workflows/e2e.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,17 @@ jobs:
4646
onesignal-app-id: ${{ vars.APPIUM_ONESIGNAL_APP_ID }}
4747
onesignal-api-key: ${{ secrets.APPIUM_ONESIGNAL_API_KEY }}
4848

49+
- name: Resolve OneSignal Android SDK version
50+
id: android-sdk-version
51+
run: |
52+
VERSION=$(grep "com.onesignal:OneSignal:" android/build.gradle | sed -E "s/.*OneSignal:([0-9.]+).*/\1/")
53+
echo "version=${VERSION}" >> "$GITHUB_OUTPUT"
54+
55+
- name: Wait for OneSignal Android SDK on Maven Central
56+
uses: OneSignal/sdk-shared/.github/actions/wait-for-maven-artifact@main
57+
with:
58+
version: ${{ steps.android-sdk-version.outputs.version }}
59+
4960
- name: Build release APK
5061
working-directory: examples/demo/android
5162
run: ./gradlew assembleRelease --quiet --console=plain --warning-mode=summary

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies {
3636
// api is used instead of implementation so the parent :app project can access any of the OneSignal Java
3737
// classes if needed. Such as com.onesignal.NotificationExtenderService
3838
//
39-
// Exclude OkHttp from OneSignal's transitive deps: the 5.7.x otel module pulls in OkHttp 5.x
39+
// Exclude OkHttp from OneSignal's transitive deps: the otel module pulls in OkHttp 5.x
4040
// (via opentelemetry-exporter-sender-okhttp) which is binary-incompatible with React Native's
4141
// networking stack (okhttp3.internal.Util removed in 5.x). React Native already provides OkHttp 4.x.
4242
api('com.onesignal:OneSignal:5.8.0') {

android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ public void invalidate() {
230230
@Override
231231
public void initialize(String appId) {
232232
OneSignalWrapper.setSdkType("reactnative");
233-
OneSignalWrapper.setSdkVersion("050213");
233+
OneSignalWrapper.setSdkVersion("050404");
234234

235235
if (oneSignalInitDone) {
236236
Logging.debug("Already initialized the OneSignal React-Native SDK", null);

examples/demo/bun.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ios/RCTOneSignal/RCTOneSignal.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ - (void)initOneSignal:(NSDictionary *)launchOptions {
2323
return;
2424

2525
OneSignalWrapper.sdkType = @"reactnative";
26-
OneSignalWrapper.sdkVersion = @"050213";
26+
OneSignalWrapper.sdkVersion = @"050404";
2727
// initialize the SDK with a nil app ID so cold start click listeners can be
2828
// triggered
2929
[OneSignal initialize:nil withLaunchOptions:launchOptions];

0 commit comments

Comments
 (0)