Skip to content

Commit 492ec3e

Browse files
committed
ci: fix Android version parsing in release workflow
1 parent 2ffcc1b commit 492ec3e

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
9595
# Get versions from target branch (not the release branch)
9696
CURRENT_VERSION=$(git show origin/${{ inputs.target_branch }}:package.json | jq -r .version)
97-
ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | grep "api 'com.onesignal:OneSignal:" | sed -E "s/.*OneSignal:([0-9.]+).*/\1/")
97+
ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/build.gradle | grep "com.onesignal:OneSignal:" | sed -E "s/.*OneSignal:([0-9.]+).*/\1/")
9898
IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:react-native-onesignal.podspec | grep "OneSignalXCFramework" | sed -E "s/.*'([0-9.]+)'.*/\1/")
9999
100100
echo "rn_from=$CURRENT_VERSION" >> $GITHUB_OUTPUT
@@ -116,8 +116,8 @@ jobs:
116116
exit 1
117117
fi
118118
119-
# Update Android SDK version in build.gradle
120-
sed -i '' "s/api 'com.onesignal:OneSignal:[^']*'/api 'com.onesignal:OneSignal:$VERSION'/" android/build.gradle
119+
# Update Android SDK version in build.gradle (handles both api '...' and api('...') syntax)
120+
sed -i '' -E "s/(com\.onesignal:OneSignal:)[0-9.]+/\1$VERSION/" android/build.gradle
121121
echo "✓ Updated android/build.gradle with Android SDK ${VERSION}"
122122
123123
# Only commit if there are changes

0 commit comments

Comments
 (0)