Skip to content

Commit ba9e1d4

Browse files
committed
chore(demo): update iOS project and lockfile
1 parent 797af4d commit ba9e1d4

14 files changed

Lines changed: 2502 additions & 41 deletions

File tree

.github/actions/setup-demo/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ runs:
2424
uses: oven-sh/setup-bun@v2
2525

2626
- name: Cache bun dependencies
27-
uses: actions/cache@v4
27+
uses: actions/cache@v5
2828
with:
2929
path: examples/demo/node_modules
3030
key: bun-${{ runner.os }}-${{ hashFiles('examples/demo/bun.lock') }}
@@ -34,12 +34,12 @@ runs:
3434
shell: bash
3535
working-directory: examples/demo
3636
run: |
37-
bun install
3837
bun run setup
38+
bun install
3939
4040
- name: Cache CocoaPods
4141
if: inputs.install-pods == 'true'
42-
uses: actions/cache@v4
42+
uses: actions/cache@v5
4343
with:
4444
path: examples/demo/ios/Pods
4545
key: pods-${{ runner.os }}-${{ hashFiles('examples/demo/ios/Podfile.lock') }}

.github/workflows/e2e.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,6 @@ jobs:
9090
asc-key-id: ${{ secrets.APPIUM_APP_STORE_CONNECT_KEY_ID }}
9191
asc-issuer-id: ${{ secrets.APPIUM_APP_STORE_CONNECT_ISSUER_ID }}
9292
asc-private-key: ${{ secrets.APPIUM_APP_STORE_CONNECT_PRIVATE_KEY }}
93-
nse-bundle-id: com.onesignal.example.OneSignalNotificationServiceExtensionRN
94-
widget-bundle-id: com.onesignal.example.OneSignalWidgetExtension
9593

9694
- name: Build signed IPA
9795
working-directory: examples/demo/ios

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ build
1515
dist
1616
android/build
1717
*.tgz
18-
.sdk-build-stamp
18+
.rn-sdk-source.stamp
1919

2020
# OSX
2121
#

examples/build_ios.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,15 +271,15 @@ The `project.pbxproj` needs native target entries for both extensions. These are
271271
**OneSignalNotificationServiceExtension target** (`com.apple.product-type.app-extension`):
272272

273273
- Sources, Frameworks, Resources build phases
274-
- `PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.example.OneSignalNotificationServiceExtensionRN` (must be prefixed with the parent app bundle ID)
274+
- `PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.example.NSE` (must be prefixed with the parent app bundle ID)
275275
- `CODE_SIGN_ENTITLEMENTS = OneSignalNotificationServiceExtension/OneSignalNotificationServiceExtension.entitlements`
276276
- `INFOPLIST_FILE = OneSignalNotificationServiceExtension/Info.plist`
277277
- `SKIP_INSTALL = YES`, `SWIFT_VERSION = 5.0`, `IPHONEOS_DEPLOYMENT_TARGET = 13.0`
278278

279279
**OneSignalWidgetExtension target** (`com.apple.product-type.app-extension`):
280280

281281
- Sources, Frameworks (linking WidgetKit.framework and SwiftUI.framework), Resources build phases
282-
- `PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.example.OneSignalWidgetExtension`
282+
- `PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.example.LA`
283283
- `INFOPLIST_FILE = OneSignalWidget/Info.plist` (note: folder is `OneSignalWidget`, not `OneSignalWidgetExtension`)
284284
- `SKIP_INSTALL = YES`, `SWIFT_VERSION = 5.0`, `IPHONEOS_DEPLOYMENT_TARGET = 16.2` (Live Activities require iOS 16.2+)
285285

examples/demo/bun.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/demo/ios/ExportOptions.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
<dict>
1515
<key>com.onesignal.example</key>
1616
<string>Appium OneSignal Main</string>
17-
<key>com.onesignal.example.OneSignalNotificationServiceExtensionRN</key>
17+
<key>com.onesignal.example.NSE</key>
1818
<string>Appium OneSignal NSE RN</string>
19-
<key>com.onesignal.example.OneSignalWidgetExtension</key>
19+
<key>com.onesignal.example.LA</key>
2020
<string>Appium OneSignal Widget RN</string>
2121
</dict>
2222
</dict>

0 commit comments

Comments
 (0)