Skip to content

Commit c0d925a

Browse files
committed
clean up hooks
1 parent ece6e02 commit c0d925a

2 files changed

Lines changed: 14 additions & 17 deletions

File tree

android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -179,20 +179,20 @@ private void removeObservers() {
179179

180180
private void removeHandlers() {
181181
if (hasAddedInAppMessageClickListener) {
182-
OneSignal.getInAppMessages().removeClickListener(rnInAppClickListener);
183-
hasAddedInAppMessageClickListener = false;
182+
OneSignal.getInAppMessages().removeClickListener(rnInAppClickListener);
183+
hasAddedInAppMessageClickListener = false;
184184
}
185185
if (hasAddedInAppMessageLifecycleListener) {
186-
OneSignal.getInAppMessages().removeLifecycleListener(rnInAppLifecycleListener);
187-
hasAddedInAppMessageLifecycleListener = false;
186+
OneSignal.getInAppMessages().removeLifecycleListener(rnInAppLifecycleListener);
187+
hasAddedInAppMessageLifecycleListener = false;
188188
}
189189
if (hasAddedNotificationClickListener) {
190-
OneSignal.getNotifications().removeClickListener(rnNotificationClickListener);
191-
hasAddedNotificationClickListener = false;
190+
OneSignal.getNotifications().removeClickListener(rnNotificationClickListener);
191+
hasAddedNotificationClickListener = false;
192192
}
193193
if (hasAddedNotificationForegroundListener) {
194-
OneSignal.getNotifications().removeForegroundLifecycleListener(this);
195-
hasAddedNotificationForegroundListener = false;
194+
OneSignal.getNotifications().removeForegroundLifecycleListener(this);
195+
hasAddedNotificationForegroundListener = false;
196196
}
197197
}
198198

examples/RNOneSignalTS/OSDemo.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,13 @@ const OSDemo: React.FC = () => {
135135
);
136136

137137
useEffect(() => {
138-
const initializeOneSignal = async () => {
139-
OneSignal.initialize(APP_ID);
140-
OneSignal.Debug.setLogLevel(LogLevel.None);
138+
OneSignal.initialize(APP_ID);
139+
OneSignal.Debug.setLogLevel(LogLevel.None);
140+
}, []);
141141

142+
useEffect(() => {
143+
const setup = async () => {
142144
OneSignal.LiveActivities.setupDefault();
143-
// OneSignal.LiveActivities.setupDefault({
144-
// enablePushToStart: false,
145-
// enablePushToUpdate: true,
146-
// });
147-
148145
OneSignal.Notifications.addEventListener(
149146
'foregroundWillDisplay',
150147
onForegroundWillDisplay,
@@ -166,7 +163,7 @@ const OSDemo: React.FC = () => {
166163
OneSignal.User.addEventListener('change', onUserChange);
167164
};
168165

169-
initializeOneSignal();
166+
setup();
170167

171168
return () => {
172169
// Clean up all event listeners

0 commit comments

Comments
 (0)