Skip to content

Commit e3f787f

Browse files
committed
chore(demo): bump iOS deployment target to 15.1
1 parent 1d1c777 commit e3f787f

5 files changed

Lines changed: 22 additions & 19 deletions

File tree

.github/actions/setup-demo/action.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ runs:
2020
cache: true
2121
run-install: true
2222

23-
- name: Set up Bun
24-
uses: oven-sh/setup-bun@v2
25-
2623
- name: Cache bun dependencies
2724
uses: actions/cache@v5
2825
with:

.github/workflows/create-release-pr.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,19 @@ jobs:
140140
sed -i '' "s/s\.dependency 'OneSignalXCFramework', '[^']*'/s.dependency 'OneSignalXCFramework', '$VERSION'/" react-native-onesignal.podspec
141141
echo "✓ Updated react-native-onesignal.podspec with iOS SDK ${VERSION}"
142142
143+
# Update demo app's Podfile.lock with the new iOS SDK version.
144+
# setup.sh repacks the SDK tarball (so node_modules sees the new pin),
145+
# then pod update rewrites the OneSignalXCFramework lock entry only.
146+
# --no-repo-update is fine because trunk is a CDN and serves the new
147+
# spec on demand without a local refresh.
148+
(
149+
cd examples/demo
150+
vp run setup
151+
cd ios
152+
pod update OneSignalXCFramework --no-repo-update
153+
)
154+
echo "✓ Updated examples/demo/ios/Podfile.lock to OneSignalXCFramework ${VERSION}"
155+
143156
# Only commit if there are changes
144157
git add -A
145158
git diff --staged --quiet && exit 0

examples/demo/ios/demo.xcodeproj/project.pbxproj

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -366,14 +366,10 @@
366366
inputFileListPaths = (
367367
"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-frameworks-${CONFIGURATION}-input-files.xcfilelist",
368368
);
369-
inputPaths = (
370-
);
371369
name = "[CP] Embed Pods Frameworks";
372370
outputFileListPaths = (
373371
"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-frameworks-${CONFIGURATION}-output-files.xcfilelist",
374372
);
375-
outputPaths = (
376-
);
377373
runOnlyForDeploymentPostprocessing = 0;
378374
shellPath = /bin/sh;
379375
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-frameworks.sh\"\n";
@@ -431,14 +427,10 @@
431427
inputFileListPaths = (
432428
"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-resources-${CONFIGURATION}-input-files.xcfilelist",
433429
);
434-
inputPaths = (
435-
);
436430
name = "[CP] Copy Pods Resources";
437431
outputFileListPaths = (
438432
"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-resources-${CONFIGURATION}-output-files.xcfilelist",
439433
);
440-
outputPaths = (
441-
);
442434
runOnlyForDeploymentPostprocessing = 0;
443435
shellPath = /bin/sh;
444436
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-demo/Pods-demo-resources.sh\"\n";
@@ -750,7 +742,7 @@
750742
CURRENT_PROJECT_VERSION = 1;
751743
DEVELOPMENT_TEAM = 99SW8E36CT;
752744
INFOPLIST_FILE = OneSignalNotificationServiceExtension/Info.plist;
753-
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
745+
IPHONEOS_DEPLOYMENT_TARGET = 15.1;
754746
LD_RUNPATH_SEARCH_PATHS = (
755747
"$(inherited)",
756748
"@executable_path/Frameworks",
@@ -776,7 +768,7 @@
776768
DEVELOPMENT_TEAM = "";
777769
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 99SW8E36CT;
778770
INFOPLIST_FILE = OneSignalNotificationServiceExtension/Info.plist;
779-
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
771+
IPHONEOS_DEPLOYMENT_TARGET = 15.1;
780772
LD_RUNPATH_SEARCH_PATHS = (
781773
"$(inherited)",
782774
"@executable_path/Frameworks",

examples/demo/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"preios": "bun run setup",
99
"android": "bash ../run-android.sh",
1010
"ios": "bash ../run-ios.sh",
11-
"update:pods": "cd ios && pod update OneSignalXCFramework --no-repo-update && cd ..",
11+
"update:pods": "cd ios && pod update OneSignalXCFramework && cd ..",
1212
"clean:android": "rm -rf android/app/build android/app/.cxx android/build && adb uninstall com.onesignal.example >/dev/null 2>&1 || true",
1313
"clean:ios": "rm -rf ios/build ios/Pods",
1414
"start": "react-native start"
@@ -44,5 +44,6 @@
4444
},
4545
"engines": {
4646
"node": ">= 22.11.0"
47-
}
47+
},
48+
"packageManager": "bun@1.3.13"
4849
}

examples/setup.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ if [ "${FORCE_SETUP:-0}" != "1" ] \
3838
fi
3939

4040
cd "$SDK_ROOT"
41-
bun run build
41+
vp run build
4242

4343
# `bun pm pack` honors package.json's "files" field (so the tarball matches
4444
# what would actually be published). The version suffix in the filename
4545
# is unstable, so we normalize to react-native-onesignal.tgz for a
4646
# deterministic path that package.json + the extract step can reference.
4747
rm -f react-native-onesignal*.tgz
48-
bun pm pack
48+
vp pm pack
4949
mv react-native-onesignal-*.tgz react-native-onesignal.tgz
5050

5151
cd "$ORIGINAL_DIR"
@@ -63,8 +63,8 @@ cd "$ORIGINAL_DIR"
6363
# path is intentional — an absolute path would leak this machine's
6464
# layout into the lockfile.
6565
echo "Registering tarball with bun (refreshes bun.lock integrity hash)..."
66-
bun remove react-native-onesignal 2>/dev/null || true
67-
bun add file:../../react-native-onesignal.tgz
66+
vp remove react-native-onesignal 2>/dev/null || true
67+
vp add file:../../react-native-onesignal.tgz
6868

6969
# Record the hash only after a successful build/install so that an
7070
# interrupted run forces a full retry next time.

0 commit comments

Comments
 (0)