Skip to content

Commit e893a14

Browse files
committed
refactor: update TurboModule types from object to Object
1 parent 951dc2a commit e893a14

3 files changed

Lines changed: 46 additions & 25 deletions

File tree

examples/demo/bun.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/demo/ios/Podfile.lock

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,8 +1447,28 @@ PODS:
14471447
- ReactCommon/turbomodule/core
14481448
- ReactNativeDependencies
14491449
- react-native-onesignal (5.3.4):
1450-
- OneSignalXCFramework (= 5.5.0)
1451-
- React (< 1.0.0, >= 0.13.0)
1450+
- hermes-engine
1451+
- OneSignalXCFramework (= 5.4.2)
1452+
- RCTRequired
1453+
- RCTTypeSafety
1454+
- React-Core
1455+
- React-Core-prebuilt
1456+
- React-debug
1457+
- React-Fabric
1458+
- React-featureflags
1459+
- React-graphics
1460+
- React-ImageManager
1461+
- React-jsi
1462+
- React-NativeModulesApple
1463+
- React-RCTFabric
1464+
- React-renderercss
1465+
- React-rendererdebug
1466+
- React-utils
1467+
- ReactCodegen
1468+
- ReactCommon/turbomodule/bridging
1469+
- ReactCommon/turbomodule/core
1470+
- ReactNativeDependencies
1471+
- Yoga
14521472
- react-native-safe-area-context (5.6.2):
14531473
- hermes-engine
14541474
- RCTRequired
@@ -2329,7 +2349,7 @@ SPEC CHECKSUMS:
23292349
React-logger: 9e51e01455f15cb3ef87a09a1ec773cdb22d56c1
23302350
React-Mapbuffer: 92b99e450e8ff598b27d6e4db3a75e04fd45e9a9
23312351
React-microtasksnativemodule: 2fe0f2bd2840dedbd66c0ac249c64f977f39cc18
2332-
react-native-onesignal: 3c595a8e3ee0ac2baca06cbdbff489d0a006d782
2352+
react-native-onesignal: 3ad7ccd00e4ea2b4f433e579f897b356747ae548
23332353
react-native-safe-area-context: 37e680fc4cace3c0030ee46e8987d24f5d3bdab2
23342354
React-NativeModulesApple: 44a9474594566cd03659f92e38f42599c6b9dee4
23352355
React-networking: db73d91466cb134fcbdaaa579fb2de14e2c2ea01

src/NativeOneSignal.ts

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import type { TurboModule, CodegenTypes } from 'react-native';
1+
/* eslint-disable @typescript-eslint/no-wrapper-object-types */
2+
import type { CodegenTypes, TurboModule } from 'react-native';
23
import { TurboModuleRegistry } from 'react-native';
34

45
export interface Spec extends TurboModule {
@@ -17,19 +18,19 @@ export interface Spec extends TurboModule {
1718
enterLiveActivity(
1819
activityId: string,
1920
token: string,
20-
callback: (result: object) => void,
21+
callback: (result: Object) => void,
2122
): void;
2223
exitLiveActivity(
2324
activityId: string,
24-
callback: (result: object) => void,
25+
callback: (result: Object) => void,
2526
): void;
2627
setPushToStartToken(activityType: string, token: string): void;
2728
removePushToStartToken(activityType: string): void;
28-
setupDefaultLiveActivity(options: object | null): void;
29+
setupDefaultLiveActivity(options: Object | null): void;
2930
startDefaultLiveActivity(
3031
activityId: string,
31-
attributes: object,
32-
content: object,
32+
attributes: Object,
33+
content: Object,
3334
): void;
3435

3536
// Push Subscription
@@ -46,7 +47,7 @@ export interface Spec extends TurboModule {
4647
getExternalId(): Promise<string | null>;
4748
setLanguage(language: string): void;
4849
addAlias(label: string, id: string): void;
49-
addAliases(aliases: object): void;
50+
addAliases(aliases: Object): void;
5051
removeAlias(label: string): void;
5152
removeAliases(labels: string[]): void;
5253
addEmail(email: string): void;
@@ -55,10 +56,10 @@ export interface Spec extends TurboModule {
5556
removeSms(smsNumber: string): void;
5657
addTag(key: string, value: string): void;
5758
removeTag(key: string): void;
58-
addTags(tags: object): void;
59+
addTags(tags: Object): void;
5960
removeTags(keys: string[]): void;
60-
getTags(): Promise<object>;
61-
trackEvent(name: string, properties: object): void;
61+
getTags(): Promise<Object>;
62+
trackEvent(name: string, properties: Object | null): void;
6263

6364
// Notifications
6465
hasNotificationPermission(): Promise<boolean>;
@@ -81,7 +82,7 @@ export interface Spec extends TurboModule {
8182
addInAppMessageClickListener(): void;
8283
addInAppMessagesLifecycleListener(): void;
8384
addTrigger(key: string, value: string): void;
84-
addTriggers(triggers: object): void;
85+
addTriggers(triggers: Object): void;
8586
removeTrigger(key: string): void;
8687
removeTriggers(keys: string[]): void;
8788
clearTriggers(): void;
@@ -99,16 +100,16 @@ export interface Spec extends TurboModule {
99100
addOutcomeWithValue(name: string, value: number): void;
100101

101102
// Events
102-
readonly onPermissionChanged: CodegenTypes.EventEmitter<object>;
103-
readonly onSubscriptionChanged: CodegenTypes.EventEmitter<object>;
104-
readonly onUserStateChanged: CodegenTypes.EventEmitter<object>;
105-
readonly onNotificationWillDisplay: CodegenTypes.EventEmitter<object>;
106-
readonly onNotificationClicked: CodegenTypes.EventEmitter<object>;
107-
readonly onInAppMessageClicked: CodegenTypes.EventEmitter<object>;
108-
readonly onInAppMessageWillDisplay: CodegenTypes.EventEmitter<object>;
109-
readonly onInAppMessageDidDisplay: CodegenTypes.EventEmitter<object>;
110-
readonly onInAppMessageWillDismiss: CodegenTypes.EventEmitter<object>;
111-
readonly onInAppMessageDidDismiss: CodegenTypes.EventEmitter<object>;
103+
readonly onPermissionChanged: CodegenTypes.EventEmitter<Object>;
104+
readonly onSubscriptionChanged: CodegenTypes.EventEmitter<Object>;
105+
readonly onUserStateChanged: CodegenTypes.EventEmitter<Object>;
106+
readonly onNotificationWillDisplay: CodegenTypes.EventEmitter<Object>;
107+
readonly onNotificationClicked: CodegenTypes.EventEmitter<Object>;
108+
readonly onInAppMessageClicked: CodegenTypes.EventEmitter<Object>;
109+
readonly onInAppMessageWillDisplay: CodegenTypes.EventEmitter<Object>;
110+
readonly onInAppMessageDidDisplay: CodegenTypes.EventEmitter<Object>;
111+
readonly onInAppMessageWillDismiss: CodegenTypes.EventEmitter<Object>;
112+
readonly onInAppMessageDidDismiss: CodegenTypes.EventEmitter<Object>;
112113
}
113114

114115
export default TurboModuleRegistry.getEnforcing<Spec>('OneSignal');

0 commit comments

Comments
 (0)