Skip to content

Commit f1fd368

Browse files
authored
fix: [SDK-4346] resolve strict CodeGen rules preventing RN/Expo apps from building (#1939)
1 parent 875b98b commit f1fd368

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

examples/run-android.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,4 @@ else
3737
selected="${devices[$idx]}"
3838
fi
3939

40-
cd "$(dirname "$0")/demo"
4140
ANDROID_SERIAL="$selected" bunx react-native run-android --deviceId "$selected"

examples/run-ios.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,5 +70,4 @@ name="${selected%%|*}"
7070
udid="${selected##*|}"
7171
echo "Using simulator: $name ($udid)"
7272

73-
cd "$(dirname "$0")/demo"
7473
bunx react-native run-ios --udid "$udid"

src/NativeOneSignal.ts

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/* eslint-disable @typescript-eslint/no-wrapper-object-types */
2-
import type { CodegenTypes, TurboModule } from 'react-native';
2+
import type { TurboModule } from 'react-native';
33
import { TurboModuleRegistry } from 'react-native';
4+
import type { EventEmitter } from 'react-native/Libraries/Types/CodegenTypes';
45

56
export interface Spec extends TurboModule {
67
// OneSignal root
@@ -90,16 +91,16 @@ export interface Spec extends TurboModule {
9091
addOutcomeWithValue(name: string, value: number): void;
9192

9293
// Events
93-
readonly onPermissionChanged: CodegenTypes.EventEmitter<Object>;
94-
readonly onSubscriptionChanged: CodegenTypes.EventEmitter<Object>;
95-
readonly onUserStateChanged: CodegenTypes.EventEmitter<Object>;
96-
readonly onNotificationWillDisplay: CodegenTypes.EventEmitter<Object>;
97-
readonly onNotificationClicked: CodegenTypes.EventEmitter<Object>;
98-
readonly onInAppMessageClicked: CodegenTypes.EventEmitter<Object>;
99-
readonly onInAppMessageWillDisplay: CodegenTypes.EventEmitter<Object>;
100-
readonly onInAppMessageDidDisplay: CodegenTypes.EventEmitter<Object>;
101-
readonly onInAppMessageWillDismiss: CodegenTypes.EventEmitter<Object>;
102-
readonly onInAppMessageDidDismiss: CodegenTypes.EventEmitter<Object>;
94+
readonly onPermissionChanged: EventEmitter<Object>;
95+
readonly onSubscriptionChanged: EventEmitter<Object>;
96+
readonly onUserStateChanged: EventEmitter<Object>;
97+
readonly onNotificationWillDisplay: EventEmitter<Object>;
98+
readonly onNotificationClicked: EventEmitter<Object>;
99+
readonly onInAppMessageClicked: EventEmitter<Object>;
100+
readonly onInAppMessageWillDisplay: EventEmitter<Object>;
101+
readonly onInAppMessageDidDisplay: EventEmitter<Object>;
102+
readonly onInAppMessageWillDismiss: EventEmitter<Object>;
103+
readonly onInAppMessageDidDismiss: EventEmitter<Object>;
103104
}
104105

105106
export default TurboModuleRegistry.getEnforcing<Spec>('OneSignal');

0 commit comments

Comments
 (0)