Android build fails with RN 0.79 — RNOneSignal method signatures don't match codegen NativeOneSignalSpec

[Jora4e]

react-native-onesignal@5.4.1 fails to compile on Android with React Native 0.79.0. The codegen-generated NativeOneSignalSpec
produces method signatures that don't match the RNOneSignal.java implementation.

Environment

• react-native: 0.79.0
• react-native-onesignal: 5.4.1
• Kotlin: 2.0.21
• Gradle: 8.13
• Android Gradle Plugin: 8.8.2
• newArchEnabled: true

Error

RNOneSignal is not abstract and does not override the abstract method addTriggers(String) in NativeOneSignalSpec

7 methods have mismatched signatures:

Method	NativeOneSignalSpec (codegen)	RNOneSignal.java
addTriggers	String	ReadableMap
addTags	String	ReadableMap
addAliases	String	ReadableMap
trackEvent (2nd param)	@Nullable String	@Nullable ReadableMap
setupDefaultLiveActivity	@Nullable String	@Nullable ReadableMap
startDefaultLiveActivity (2nd, 3rd params)	String, String	ReadableMap, ReadableMap

Root Cause

The TurboModule JS spec (NativeOneSignal.ts) declares these parameters as string (e.g. addTriggers(triggers: string)), which the
RN 0.79 codegen correctly maps to String on Android. However, the Java implementation in RNOneSignal.java still expects
ReadableMap.

The spec and the Java implementation were not aligned when TurboModule support was added in 5.4.0 (PR #1920).

Additional Issue: Kotlin version mismatch

react-native-onesignal@5.4.1 pulls com.onesignal:OneSignal:5.7.6 which is compiled with Kotlin 2.2.0. React Native 0.79.0 ships
with Kotlin 2.0.21, causing:

Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 2.2.0, expected version is 2.0.0.

Workaround

1. patch-package to fix the Java method signatures (parse JSON strings to maps internally)
2. Pin native SDK to 5.6.2 via Gradle resolutionStrategy (last version compiled with Kotlin 1.9.x, compatible with 2.0.x)

configurations.all {                                                                                                                  
    resolutionStrategy {                                                                                                           
        force 'com.onesignal:OneSignal:5.6.2'                                                                                         
        force 'com.onesignal:core:5.6.2'                                                                                              
        force 'com.onesignal:notifications:5.6.2'                                                                                     
        force 'com.onesignal:in-app-messages:5.6.2'                                                                                   
        force 'com.onesignal:location:5.6.2'                                                                                          
    }                                                                                                                                 
} 

[fadi-george]

Thanks for the report @Jora4e. We looked into this and the root cause is a bit different from what's described.
The spec in 5.4.x declares those parameters as Object, not string. We ran RN 0.79's codegen directly and Object correctly maps to ReadableMap in the generated Java code.

The actual blocker for RN 0.79 is that the spec uses CodegenTypes.EventEmitter for event properties, which RN 0.79's codegen doesn't support. It fails with UnsupportedModulePropertyParserError before any Java code is generated. RN 0.80+ handles this correctly. Also, 5.4.2 bumped the native Android SDK to 5.7.7 which lowered the Kotlin version to 1.9.25.

For now, the minimum RN version for New Architecture (TurboModules) support is 0.80 otherwise you can use old arch. Also, RN 0.79 and 0.80 are both marked as unsupported by React Native itself (0.83+ is the current active release). We'll document this more clearly.

[Jora4e]

Thanks for the response @fadi-george. The CodegenTypes.EventEmitter diagnosis is correct, but setting newArchEnabled=false on RN 0.79 doesn't help — the codegen still runs for packages that have codegenConfig in their package.json and apply plugin: 'com.facebook.react' in their build.gradle. The build still fails with UnsupportedModulePropertyParserError regardless of the newArchEnabled flag. Additionally, with newArchEnabled=false the EventEmitter properties aren't available on the native module at runtime, causing this.RNOneSignal.onPermissionChanged is not a function and crashing the app on startup. We had to patch the TS spec + Java method signatures and pin the native SDK to 5.6.2 (for Kotlin 2.0.x compatibility) to get it building and running on RN 0.79.

[fadi-george]

Yeah you're right, old arch still doesn't work for 0.79. Taking a look. Worst case, we may need to require 0.80 going forward.

[fadi-george]

Regarding this particular issue I'll close it and recommend using RN 0.80 to build (ideally with new architecure). And there's another issue reported for onPermissionChanged specifically.