chore(example): cleanup event listeners#1848
Merged
sherwinski merged 2 commits intomainfrom Oct 30, 2025
Merged
Conversation
The OSDemo component was registering 10 event listeners but never removing them during clean up. This change updates the example to provide an instance of best practices for anyone using it as a reference.
1619dff to
d4b1efa
Compare
fadi-george
approved these changes
Oct 30, 2025
Collaborator
|
Run lint fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
The OSDemo component was registering 10 event listeners but never removing them during clean up. This change updates the example to provide an instance of best practices for anyone using it as a reference.
Details
Motivation
I noticed this while testing some other event listener behavior in the library.
Scope
Scope is limited to the example app we provide in the repo.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is