fix: [SDK-4342] guard against missing EventEmitter to prevent crash on Old Architecture

[fadi-george]

Description

One Line Summary

Add a guard in EventManager.setupListeners() to prevent a crash when codegen EventEmitter functions are unavailable (Old Architecture).

Details

Motivation

Since v5.4.0, the SDK uses CodegenTypes.EventEmitter (TurboModules) for native events. If a user's app doesn't have the New Architecture enabled, onPermissionChanged and other EventEmitter properties are undefined on the native module object. Because EventManager is constructed at module import time, this causes a TypeError crash that prevents the entire SDK from loading — not just events, but all functions including initialize().

Reported in #1930

Scope

• EventManager.setupListeners() now checks typeof this.RNOneSignal.onPermissionChanged !== 'function' before subscribing to any emitters.
• If the check fails, a clear console.error is logged directing the user to enable New Architecture, and the method returns early.
• All non-event SDK functionality (initialize, login, requestPermission, etc.) continues to work normally even without event emitters.
• No changes to native code (Android/iOS).

Testing

Unit testing

Added a test case verifying that EventManager does not throw when constructed with a module object that lacks EventEmitter functions, and that the appropriate error message is logged.

Manual testing

All 245 unit tests pass. Lint, type checks, and production build (vp pack) all succeed.

Affected code checklist

• Notifications
• In-App Messaging
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor