fix: [SDK-4346] resolve strict CodeGen rules preventing RN/Expo apps from building#1939
Merged
fadi-george merged 2 commits intomainfrom Apr 9, 2026
Conversation
sherwinski
approved these changes
Apr 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Line Summary
Fix
EventEmitterimport path inNativeOneSignal.tsso React Native CodeGen doesn't fail for New Architecture builds on RN 0.76+.See error:
Motivation
React Native 0.76+ with New Architecture enabled uses stricter CodeGen module resolution. The previous
CodegenTypes.EventEmitterimport fromreact-nativedoesn't resolve correctly under these stricter rules, causing a CodeGen error that prevents the app from building entirely.This affects any RN 0.76+ or Expo user with New Architecture enabled. Importing
EventEmitterdirectly fromreact-native/Libraries/Types/CodegenTypesfixes the resolution and allows CodeGen to process the TurboModule spec successfully.Linear: SDK-4346
Scope
src/NativeOneSignal.ts-- changedEventEmitterimport fromCodegenTypes.EventEmitter(viareact-native) to a direct import fromreact-native/Libraries/Types/CodegenTypes. This resolves the CodeGen failure for New Architecture builds on RN 0.76+.examples/run-android.sh/examples/run-ios.sh-- removed stalecdintodemodirectory (unrelated cleanup)Testing
npx expo run:ios) and confirm CodeGen no longer errorsAffected code checklist
Checklist