Skip to content

fix: [SDK-4346] resolve strict CodeGen rules preventing RN/Expo apps from building #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
Apr 9, 2026
+12 −13
Merged

fix: [SDK-4346] resolve strict CodeGen rules preventing RN/Expo apps from building #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84bb231
fix(scripts): remove demo directory navigation
fadi-george Apr 9, 2026
7fd93b5
fix(types): update EventEmitter import path
fadi-george Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/run-android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,4 @@ else
selected="${devices[$idx]}"
fi

cd "$(dirname "$0")/demo"
ANDROID_SERIAL="$selected" bunx react-native run-android --deviceId "$selected"
1 change: 0 additions & 1 deletion examples/run-ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,4 @@ name="${selected%%|*}"
udid="${selected##*|}"
echo "Using simulator: $name ($udid)"

cd "$(dirname "$0")/demo"
bunx react-native run-ios --udid "$udid"
23 changes: 12 additions & 11 deletions src/NativeOneSignal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable @typescript-eslint/no-wrapper-object-types */
import type { CodegenTypes, TurboModule } from 'react-native';
import type { TurboModule } from 'react-native';
import { TurboModuleRegistry } from 'react-native';
import type { EventEmitter } from 'react-native/Libraries/Types/CodegenTypes';

export interface Spec extends TurboModule {
// OneSignal root
Expand Down Expand Up @@ -90,16 +91,16 @@ export interface Spec extends TurboModule {
addOutcomeWithValue(name: string, value: number): void;

// Events
readonly onPermissionChanged: CodegenTypes.EventEmitter<Object>;
readonly onSubscriptionChanged: CodegenTypes.EventEmitter<Object>;
readonly onUserStateChanged: CodegenTypes.EventEmitter<Object>;
readonly onNotificationWillDisplay: CodegenTypes.EventEmitter<Object>;
readonly onNotificationClicked: CodegenTypes.EventEmitter<Object>;
readonly onInAppMessageClicked: CodegenTypes.EventEmitter<Object>;
readonly onInAppMessageWillDisplay: CodegenTypes.EventEmitter<Object>;
readonly onInAppMessageDidDisplay: CodegenTypes.EventEmitter<Object>;
readonly onInAppMessageWillDismiss: CodegenTypes.EventEmitter<Object>;
readonly onInAppMessageDidDismiss: CodegenTypes.EventEmitter<Object>;
readonly onPermissionChanged: EventEmitter<Object>;
readonly onSubscriptionChanged: EventEmitter<Object>;
readonly onUserStateChanged: EventEmitter<Object>;
readonly onNotificationWillDisplay: EventEmitter<Object>;
readonly onNotificationClicked: EventEmitter<Object>;
readonly onInAppMessageClicked: EventEmitter<Object>;
readonly onInAppMessageWillDisplay: EventEmitter<Object>;
readonly onInAppMessageDidDisplay: EventEmitter<Object>;
readonly onInAppMessageWillDismiss: EventEmitter<Object>;
readonly onInAppMessageDidDismiss: EventEmitter<Object>;
}

export default TurboModuleRegistry.getEnforcing<Spec>('OneSignal');
Loading