test(app): fix Samsung permission dialog handling

Author: fadi-george

appium/tests/helpers/app.ts

@@ -160,15 +160,20 @@ export async function acceptSystemAlert(timeoutMs = 10_000): Promise<string | nu
     }
 
     // Try resource-id first (most robust across OEMs), then fall back to
-    // text match. "Don't allow" contains "Allow" as a substring, so we
-    // must use exact `text()` rather than `textContains()`.
+    // clickable text/description. "Don't allow" contains "Allow" as a
+    // substring, so we must use exact match rather than `textContains()`.
+    // Samsung One UI wraps the label in a clickable container, so we also
+    // target the clickable ancestor by text or content-description.
     const allowSelectors = [
       'new UiSelector().resourceIdMatches(".*:id/permission_allow_button")',
       'new UiSelector().resourceIdMatches(".*:id/permission_allow_foreground_only_button")',
       'new UiSelector().resourceIdMatches(".*:id/permission_allow_one_time_button")',
-      'new UiSelector().text("Allow")',
-      'new UiSelector().text("ALLOW")',
-      'new UiSelector().text("While using the app")',
+      'new UiSelector().clickable(true).textMatches("(?i)^allow$")',
+      'new UiSelector().clickable(true).descriptionMatches("(?i)^allow$")',
+      'new UiSelector().clickable(true).textMatches("(?i)^while using the app$")',
+      'new UiSelector().textMatches("(?i)^allow$")',
+      'new UiSelector().descriptionMatches("(?i)^allow$")',
+      'new UiSelector().textMatches("(?i)^while using the app$")',
     ];
 
     let allowBtn: Awaited<ReturnType<typeof $>> | null = null;
@@ -198,6 +203,17 @@ export async function acceptSystemAlert(timeoutMs = 10_000): Promise<string | nu
     } catch {
       /* best-effort */
     }
+    // If we matched a non-clickable text node (common on Samsung where the
+    // label sits inside a clickable container), tap the nearest clickable
+    // ancestor so the button actually fires.
+    if ((await allowBtn.getAttribute('clickable').catch(() => 'true')) !== 'true') {
+      const clickableAncestor = await $(
+        '//*[@clickable="true" and .//*[(@text="Allow" or @content-desc="Allow")]]',
+      );
+      if (await clickableAncestor.isDisplayed().catch(() => false)) {
+        allowBtn = clickableAncestor;
+      }
+    }
     await allowBtn.click();
     return text;
   } catch {
@@ -224,7 +240,7 @@ export async function waitForAppReady(opts: { skipLogin?: boolean } = {}) {
   const alertHandled = await browser.sharedStore.get('alertHandled');
   if (!alertHandled) {
     // Accept permission dialogs until the app UI is visible.
-    await acceptSystemAlerts(5_000);
+    await acceptSystemAlerts(10_000);
     await browser.sharedStore.set('alertHandled', true);
   }