Skip to content

Commit 954e860

Browse files
committed
fix: update SDK type list and rename native platform values
Add unity, cordova, dotnet as valid SDK types. Rename ios-native -> ios, android-native -> android. Made-with: Cursor
1 parent 19b04da commit 954e860

2 files changed

Lines changed: 25 additions & 8 deletions

File tree

.github/actions/appium-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ inputs:
99
description: 'Path to built APK or .app/.ipa bundle'
1010
required: true
1111
sdk-type:
12-
description: 'SDK type: react-native, flutter, capacitor, ios-native, or android-native'
12+
description: 'SDK type: react-native, flutter, capacitor, unity, cordova, dotnet, ios, or android'
1313
required: true
1414
browserstack-username:
1515
description: 'BrowserStack username'

appium/tests/helpers/selectors.ts

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,22 @@
1-
type SdkType = "react-native" | "flutter" | "capacitor" | "ios-native" | "android-native";
1+
type SdkType =
2+
| "react-native"
3+
| "flutter"
4+
| "capacitor"
5+
| "unity"
6+
| "cordova"
7+
| "dotnet"
8+
| "ios"
9+
| "android";
210

311
const VALID_SDK_TYPES = new Set<string>([
412
"react-native",
513
"flutter",
614
"capacitor",
7-
"ios-native",
8-
"android-native",
15+
"unity",
16+
"cordova",
17+
"dotnet",
18+
"ios",
19+
"android",
920
]);
1021

1122
type Platform = "ios" | "android";
@@ -66,8 +77,11 @@ export async function byTestId(id: string) {
6677
switch (sdkType) {
6778
case "react-native":
6879
case "flutter":
69-
case "ios-native":
70-
case "android-native":
80+
case "unity":
81+
case "cordova":
82+
case "dotnet":
83+
case "ios":
84+
case "android":
7185
return $(`~${id}`);
7286
case "capacitor":
7387
return $(`[data-testid="${id}"]`);
@@ -83,8 +97,11 @@ export async function byText(text: string) {
8397
switch (sdkType) {
8498
case "react-native":
8599
case "flutter":
86-
case "ios-native":
87-
case "android-native":
100+
case "unity":
101+
case "cordova":
102+
case "dotnet":
103+
case "ios":
104+
case "android":
88105
return $(`~${text}`);
89106
case "capacitor":
90107
return $(`//*[contains(text(), "${text}")]`);

0 commit comments

Comments
 (0)