Skip to content

Commit cb8a24a

Browse files
fadi-georgefadi-george
committed
ci(ios): add demo app codesigning action
1 parent 002af32 commit cb8a24a

3 files changed

Lines changed: 135 additions & 4 deletions

File tree

‎.github/actions/setup-ios-codesigning/action.yml‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
name: 'Setup iOS Codesigning'
2+
description: 'Import an Apple Development/Distribution signing certificate and download a provisioning profile via the App Store Connect API. Call once per bundle id; the cert import is automatically skipped on repeat calls within the same job.'
3+
4+
inputs:
5+
p12-base64:
6+
description: 'Base64-encoded .p12 signing certificate'
7+
required: true
8+
p12-password:
9+
description: 'Password used when exporting the .p12'
10+
required: true
11+
asc-key-id:
12+
description: 'App Store Connect API Key ID'
13+
required: true
14+
asc-issuer-id:
15+
description: 'App Store Connect API Issuer ID'
16+
required: true
17+
asc-private-key-base64:
18+
description: 'Base64-encoded App Store Connect API private key (.p8)'
19+
required: true
20+
bundle-id:
21+
description: 'Bundle identifier of the target whose provisioning profile should be downloaded'
22+
required: true
23+
profile-type:
24+
description: 'Provisioning profile type to download (IOS_APP_DEVELOPMENT, IOS_APP_ADHOC, IOS_APP_STORE)'
25+
required: false
26+
default: 'IOS_APP_DEVELOPMENT'
27+
28+
runs:
29+
using: composite
30+
steps:
31+
- name: Check for existing signing keychain
32+
id: keychain-check
33+
shell: bash
34+
run: |
35+
if security list-keychains -d user | grep -qi signing_temp; then
36+
echo "exists=true" >> "$GITHUB_OUTPUT"
37+
else
38+
echo "exists=false" >> "$GITHUB_OUTPUT"
39+
fi
40+
41+
- name: Import signing certificate
42+
if: steps.keychain-check.outputs.exists != 'true'
43+
uses: apple-actions/import-codesign-certs@v3
44+
with:
45+
p12-file-base64: ${{ inputs.p12-base64 }}
46+
p12-password: ${{ inputs.p12-password }}
47+
keychain-password: ci-keychain
48+
49+
- name: Download provisioning profile
50+
uses: apple-actions/download-provisioning-profiles@v3
51+
with:
52+
bundle-id: ${{ inputs.bundle-id }}
53+
profile-type: ${{ inputs.profile-type }}
54+
issuer-id: ${{ inputs.asc-issuer-id }}
55+
api-key-id: ${{ inputs.asc-key-id }}
56+
api-private-key: ${{ inputs.asc-private-key-base64 }}

‎.github/actions/setup-ios-demo-codesigning/action.yml‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
name: 'Setup iOS Demo Codesigning'
2+
description: 'Import the Appium signing cert and download provisioning profiles for the OneSignal demo app (main target + optional NSE and Widget). Call this once per iOS build job in an SDK E2E workflow.'
3+
4+
inputs:
5+
p12-base64:
6+
description: 'Base64-encoded .p12 signing certificate'
7+
required: true
8+
p12-password:
9+
description: 'Password used when exporting the .p12'
10+
required: true
11+
asc-key-id:
12+
description: 'App Store Connect API Key ID'
13+
required: true
14+
asc-issuer-id:
15+
description: 'App Store Connect API Issuer ID'
16+
required: true
17+
asc-private-key-base64:
18+
description: 'Base64-encoded App Store Connect API private key (.p8)'
19+
required: true
20+
main-bundle-id:
21+
description: 'Main app bundle identifier'
22+
required: false
23+
default: 'com.onesignal.example'
24+
nse-bundle-id:
25+
description: 'Notification Service Extension bundle identifier. Leave empty to skip.'
26+
required: false
27+
default: 'com.onesignal.example.NSE'
28+
widget-bundle-id:
29+
description: 'Live Activity / Widget Extension bundle identifier. Leave empty to skip.'
30+
required: false
31+
default: 'com.onesignal.example.LA'
32+
profile-type:
33+
description: 'Provisioning profile type (IOS_APP_DEVELOPMENT, IOS_APP_ADHOC, IOS_APP_STORE)'
34+
required: false
35+
default: 'IOS_APP_DEVELOPMENT'
36+
37+
runs:
38+
using: composite
39+
steps:
40+
- name: Codesigning (main)
41+
uses: ./.github/actions/setup-ios-codesigning
42+
with:
43+
p12-base64: ${{ inputs.p12-base64 }}
44+
p12-password: ${{ inputs.p12-password }}
45+
asc-key-id: ${{ inputs.asc-key-id }}
46+
asc-issuer-id: ${{ inputs.asc-issuer-id }}
47+
asc-private-key-base64: ${{ inputs.asc-private-key-base64 }}
48+
bundle-id: ${{ inputs.main-bundle-id }}
49+
profile-type: ${{ inputs.profile-type }}
50+
51+
- name: Codesigning (NSE)
52+
if: inputs.nse-bundle-id != ''
53+
uses: ./.github/actions/setup-ios-codesigning
54+
with:
55+
p12-base64: ${{ inputs.p12-base64 }}
56+
p12-password: ${{ inputs.p12-password }}
57+
asc-key-id: ${{ inputs.asc-key-id }}
58+
asc-issuer-id: ${{ inputs.asc-issuer-id }}
59+
asc-private-key-base64: ${{ inputs.asc-private-key-base64 }}
60+
bundle-id: ${{ inputs.nse-bundle-id }}
61+
profile-type: ${{ inputs.profile-type }}
62+
63+
- name: Codesigning (Widget)
64+
if: inputs.widget-bundle-id != ''
65+
uses: ./.github/actions/setup-ios-codesigning
66+
with:
67+
p12-base64: ${{ inputs.p12-base64 }}
68+
p12-password: ${{ inputs.p12-password }}
69+
asc-key-id: ${{ inputs.asc-key-id }}
70+
asc-issuer-id: ${{ inputs.asc-issuer-id }}
71+
asc-private-key-base64: ${{ inputs.asc-private-key-base64 }}
72+
bundle-id: ${{ inputs.widget-bundle-id }}
73+
profile-type: ${{ inputs.profile-type }}

‎appium/tests/helpers/app.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,17 +189,19 @@ export async function waitForAppReady(opts: { skipLogin?: boolean } = {}) {
189189
// Want to login the user so we can clean up/delete its data on the next rerun.
190190
// `loggedIn` is module-local (worker-scoped) on purpose: each WDIO worker
191191
// runs in its own Node process and drives one device, so the cache reflects
192-
// that device's state. Sharing across workers (e.g. via sharedStore) would
193-
// lie when running parallels on BrowserStack.
194-
const loggedIn = driver.sharedStore.get('loggedIn');
192+
// that device's state.
193+
// Browserstack runs each test in a new session, so we need to set the loggedIn flag to false.
194+
const loggedIn = !process.env.BROWSERSTACK_USERNAME ? driver.sharedStore.get('loggedIn') : false;
195195
if (!loggedIn) {
196196
const testUserId = getTestExternalId();
197197
const userIdEl = await scrollToEl('user_external_id_value', { direction: 'up' });
198198
const sessionUserId = await userIdEl.getText();
199199
if (sessionUserId !== testUserId) {
200200
await loginUser(testUserId);
201201
}
202-
driver.sharedStore.set('loggedIn', true);
202+
if (!process.env.BROWSERSTACK_USERNAME) {
203+
driver.sharedStore.set('loggedIn', true);
204+
}
203205
}
204206
}
205207

0 commit comments

Comments
 (0)