test(appium): fix sharedStore login cache

Author: fadi-george

appium/tests/helpers/app.ts

@@ -162,6 +162,7 @@ export async function allowLocationWhileUsingApp() {
     'android=new UiSelector().textMatches("(?i)while using the app|only this time|allow")',
   ]);
 }
+
 /**
  * Wait for the app to fully launch and the home screen to be visible.
  *
@@ -179,16 +180,20 @@ export async function waitForAppReady(opts: { skipLogin?: boolean } = {}) {
 
   if (skipLogin) return;
 
-  // want to login user so we can't clean up/delete user data for the next rerun
-  const testUserId = getTestExternalId();
-  const loggedIn = await browser.sharedStore.get('loggedIn');
+  // Want to login the user so we can clean up/delete its data on the next rerun.
+  // `loggedIn` is module-local (worker-scoped) on purpose: each WDIO worker
+  // runs in its own Node process and drives one device, so the cache reflects
+  // that device's state. Sharing across workers (e.g. via sharedStore) would
+  // lie when running parallels on BrowserStack.
+  const loggedIn = browser.sharedStore.get('loggedIn');
   if (!loggedIn) {
+    const testUserId = getTestExternalId();
     const userIdEl = await scrollToEl('user_external_id_value', { direction: 'up' });
     const sessionUserId = await userIdEl.getText();
     if (sessionUserId !== testUserId) {
       await loginUser(testUserId);
     }
-    await browser.sharedStore.set('loggedIn', true);
+    browser.sharedStore.set('loggedIn', true);
   }
 }
 

appium/wdio.shared.conf.ts

@@ -26,7 +26,6 @@ const bstackOptions = {
 
 export const sharedConfig: WebdriverIO.Config = {
   ...(isLocal ? localConnection : browserstackConnection),
-
   maxInstances: 1,
   logLevel: 'warn',
 
@@ -62,8 +61,11 @@ export const sharedConfig: WebdriverIO.Config = {
   // BrowserStack-only: report final session status to the BrowserStack
   // dashboard. The `browserstack_executor:` script is unsupported by local
   // Appium drivers and would otherwise log "Method is not implemented".
+  // We also no-op if the session never initialized (e.g. a queue-limit
+  // rejection during session create) — `browser.executeScript` won't exist.
   after: async function (result) {
     if (isLocal) return;
+    if (typeof browser?.executeScript !== 'function') return;
     const status = result === 0 ? 'passed' : 'failed';
     const reason = result === 0 ? 'All tests passed' : 'Test failures';
     await browser.executeScript(