Skip to content

Commit 1add189

Browse files
fix(acp): increase default prompt timeout 60s to 120s for BYO-LLM proxies (#3243)
Closes #3243 - Increase DEFAULT_REQUEST_TIMEOUT_MS from 60s to 120s - Update config default acpPromptTimeoutMs to 120_000 - Update 8 test files with matching inline Config values - Add config.test.ts assertion for new default - Validated by dogfooding gap: CC could not complete within 60s through z.ai proxy
1 parent 3126220 commit 1add189

11 files changed

Lines changed: 11 additions & 10 deletions

src/__tests__/config.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ describe('config', () => {
5252
expect(config.tgGroupId).toBe('');
5353
expect(config.tgTopicTtlMs).toBe(24 * 60 * 60 * 1000);
5454
expect(config.hookSecretHeaderOnly).toBe(false);
55+
expect(config.acpPromptTimeoutMs).toBe(120_000);
5556
});
5657
});
5758

src/__tests__/health-auth-2458.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ async function buildApp(tmpDir: string): Promise<{ app: FastifyInstance; auth: A
112112
shutdownGraceMs: 15000,
113113
keyRotationGraceSeconds: 3600,
114114
shutdownHardMs: 20000,
115-
acpPromptTimeoutMs: 60_000,
115+
acpPromptTimeoutMs: 120_000,
116116
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
117117
stateStore: 'file',
118118
postgresUrl: '',

src/__tests__/mcp-integration-smoke-1898.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ async function buildTestServer(): Promise<{
218218
shutdownGraceMs: 15_000,
219219
keyRotationGraceSeconds: 3600,
220220
shutdownHardMs: 20_000,
221-
acpPromptTimeoutMs: 60_000,
221+
acpPromptTimeoutMs: 120_000,
222222
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
223223
stateStore: 'file',
224224
postgresUrl: '',

src/__tests__/oidc-auth-routes.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ function makeConfig(): Config {
103103
shutdownGraceMs: 1,
104104
keyRotationGraceSeconds: 1,
105105
shutdownHardMs: 1,
106-
acpPromptTimeoutMs: 60_000,
106+
acpPromptTimeoutMs: 120_000,
107107
stateStore: 'file',
108108
postgresUrl: '',
109109
dashboardEnabled: true,

src/__tests__/oidc-dashboard-manager.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ function makeConfig(): Config {
114114
shutdownGraceMs: 1,
115115
keyRotationGraceSeconds: 1,
116116
shutdownHardMs: 1,
117-
acpPromptTimeoutMs: 60_000,
117+
acpPromptTimeoutMs: 120_000,
118118
stateStore: 'file',
119119
postgresUrl: '',
120120
dashboardEnabled: true,

src/__tests__/server-smoke.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ async function buildRouteContext(tmpDir: string): Promise<{
117117
shutdownGraceMs: 15_000,
118118
keyRotationGraceSeconds: 3600,
119119
shutdownHardMs: 20_000,
120-
acpPromptTimeoutMs: 60_000,
120+
acpPromptTimeoutMs: 120_000,
121121
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
122122
stateStore: 'file',
123123
postgresUrl: '',

src/__tests__/session-label-2530.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ async function buildRouteContext(tmpDir: string) {
8484
strictRBAC: false,
8585
sseIdleMs: 60_000, sseClientTimeoutMs: 300_000, hookTimeoutMs: 10_000,
8686
shutdownGraceMs: 15_000, keyRotationGraceSeconds: 3600, shutdownHardMs: 20_000,
87-
acpPromptTimeoutMs: 60_000,
87+
acpPromptTimeoutMs: 120_000,
8888
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
8989
stateStore: 'file', postgresUrl: '', defaultTenantId: 'default', acpEnabled: false,
9090
tenantWorkdirs: {},

src/__tests__/session-name-validation-3091.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ async function buildRouteContext(tmpDir: string) {
8585
strictRBAC: false,
8686
sseIdleMs: 60_000, sseClientTimeoutMs: 300_000, hookTimeoutMs: 10_000,
8787
shutdownGraceMs: 15_000, keyRotationGraceSeconds: 3600, shutdownHardMs: 20_000,
88-
acpPromptTimeoutMs: 60_000,
88+
acpPromptTimeoutMs: 120_000,
8989
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
9090
stateStore: 'file', postgresUrl: '', defaultTenantId: 'default', acpEnabled: false,
9191
tenantWorkdirs: {},

src/__tests__/version-endpoint-2814.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ async function buildApp(tmpDir: string): Promise<FastifyInstance> {
111111
shutdownGraceMs: 15000,
112112
keyRotationGraceSeconds: 3600,
113113
shutdownHardMs: 20000,
114-
acpPromptTimeoutMs: 60_000,
114+
acpPromptTimeoutMs: 120_000,
115115
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
116116
stateStore: 'file',
117117
postgresUrl: '',

src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ const defaults: Config = {
233233
postgresUrl: '',
234234
rateLimit: { enabled: true, sessionsMax: 100, generalMax: 30, timeWindowSec: 60 },
235235
acpEnabled: true,
236-
acpPromptTimeoutMs: 60_000, // Issue #3223: 60s default for BYO-LLM proxy setups
236+
acpPromptTimeoutMs: 120_000, // Issue #3243: 120s default for BYO-LLM proxy setups
237237
};
238238

239239
/** Parse CLI args for --config flag */

0 commit comments

Comments
 (0)