fix(dashboard): add type='button' to 96 buttons across 36 files

Adds type="button" to all buttons missing explicit type attribute to prevent latent form-submit bugs. Recovery from botched remerge of #3292.

Author: OneStepAt4time

dashboard/src/__tests__/a11y-pages.test.tsx

@@ -25,7 +25,7 @@ import Layout from '../components/Layout';
 vi.mock('../components/overview/HomeStatusPanel', () => ({
   default: ({ onCreateFirstSession }: { onCreateFirstSession: () => void }) => (
     <div data-testid="home-status-panel">
-      <button onClick={onCreateFirstSession}>Create first session</button>
+      <button type="button" onClick={onCreateFirstSession}>Create first session</button>
     </div>
   ),
 }));

dashboard/src/__tests__/i18n-context.test.tsx

@@ -16,7 +16,7 @@ function TestComponent() {
       <div data-testid="title">{t('overview.title')}</div>
       <div data-testid="subtitle">{t('overview.subtitle')}</div>
       <div data-testid="missing">{t('nonexistent.key')}</div>
-      <button onClick={() => setLocale('de-DE')}>Change to German</button>
+      <button type="button" onClick={() => setLocale('de-DE')}>Change to German</button>
     </div>
   );
 }

dashboard/src/__tests__/i18n-integration.test.tsx

@@ -67,8 +67,8 @@ describe('i18n integration', () => {
         <div>
           <span data-testid="current-locale">{locale}</span>
           <span>{t('settings.display.title')}</span>
-          <button onClick={() => setLocale('it-IT')}>Switch to Italian</button>
-          <button onClick={() => setLocale('en-US')}>Switch to English</button>
+          <button type="button" onClick={() => setLocale('it-IT')}>Switch to Italian</button>
+          <button type="button" onClick={() => setLocale('en-US')}>Switch to English</button>
         </div>
       );
     }
@@ -94,7 +94,7 @@ describe('i18n integration', () => {
   it('persists locale choice to localStorage', () => {
     function LocaleWriter() {
       const { setLocale } = useLocale();
-      return <button onClick={() => setLocale('it-IT')}>Set Italian</button>;
+      return <button type="button" onClick={() => setLocale('it-IT')}>Set Italian</button>;
     }
 
     render(

dashboard/src/components/ActivityStream.tsx

@@ -210,7 +210,7 @@ export default function ActivityStream({
 
             {/* Clear filters */}
             {(filterSession || filterType) && (
-              <button
+              <button type="button"
                 onClick={() => { setFilterSession(null); setFilterType(null); }}
                 className="min-h-[44px] min-w-[44px] flex items-center justify-center text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)]"
               >

dashboard/src/components/CreatePipelineModal.tsx

@@ -124,7 +124,7 @@ export default function CreatePipelineModal({ open, onClose }: CreatePipelineMod
         {/* Header */}
         <div className="flex items-center justify-between px-4 sm:px-5 py-4 border-b border-[var(--color-void-lighter)]">
           <h2 className="text-sm font-semibold text-[var(--color-text-primary)]">New Pipeline</h2>
-          <button aria-label={t("aria.close")}
+          <button type="button" aria-label={t("aria.close")}
             onClick={handleClose}
             className="min-h-[44px] min-w-[44px] flex items-center justify-center text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)] transition-colors"
           >

dashboard/src/components/CreateSessionModal.tsx

@@ -237,7 +237,7 @@ export default function CreateSessionModal({ open, onClose }: CreateSessionModal
               )}
             </div>
           </div>
-          <button aria-label={t("aria.close")}
+          <button type="button" aria-label={t("aria.close")}
             onClick={handleClose}
             className="min-h-[44px] min-w-[44px] flex items-center justify-center text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)] transition-colors"
           >

dashboard/src/components/KeyboardShortcutsHelp/index.tsx

@@ -42,7 +42,7 @@ export function KeyboardShortcutsHelp({
             <Keyboard className="h-5 w-5 text-[var(--color-accent-cyan)]" />
             <h2 className="text-lg font-semibold text-[var(--color-text-primary)]">Keyboard Shortcuts</h2>
           </div>
-          <button
+          <button type="button"
             onClick={onClose}
             className="rounded p-1 text-[var(--color-text-muted)] hover:bg-[var(--color-void-lighter)]/50 hover:text-[var(--color-text-primary)] transition-colors"
             aria-label={t("aria.close")}

dashboard/src/components/SaveTemplateModal.tsx

@@ -103,7 +103,7 @@ export default function SaveTemplateModal({ open, onClose, sessionId }: SaveTemp
         {/* Header */}
         <div className="flex items-center justify-between px-4 sm:px-5 py-4 border-b border-[var(--color-void-lighter)]">
           <h2 className="text-sm font-semibold text-[var(--color-text-primary)]">Save as Template</h2>
-          <button aria-label={t("aria.close")}
+          <button type="button" aria-label={t("aria.close")}
             onClick={handleClose}
             className="min-h-[44px] min-w-[44px] flex items-center justify-center text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)] transition-colors"
           >

dashboard/src/components/TemplateModal.tsx

@@ -166,7 +166,7 @@ export default function TemplateModal({ open, onClose, template, onSaved }: Temp
           <h2 className="text-sm font-semibold text-[var(--color-text-primary)]">
             {isEditing ? 'Edit Template' : 'Create Template'}
           </h2>
-          <button aria-label={t("aria.close")}
+          <button type="button" aria-label={t("aria.close")}
             onClick={handleClose}
             className="min-h-[44px] min-w-[44px] flex items-center justify-center text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)] transition-colors"
           >

dashboard/src/components/ToastContainer.tsx

@@ -130,7 +130,7 @@ function ToastItem({
         )}
       </div>
       {undoAction && (
-        <button
+        <button type="button"
           onClick={handleUndo}
           className="shrink-0 flex items-center gap-1 rounded px-2 py-1 text-xs font-medium opacity-80 hover:opacity-100 transition-opacity bg-current/10"
           aria-label={t("aria.undo")}
@@ -139,7 +139,7 @@ function ToastItem({
           Undo
         </button>
       )}
-      <button
+      <button type="button"
         onClick={() => removeToast(id)}
         className="shrink-0 rounded p-0.5 opacity-60 hover:opacity-100 transition-opacity"
         aria-label={t("aria.dismiss")}
@@ -165,7 +165,7 @@ export default function ToastContainer() {
     >
       {toasts.length > 1 && (
         <div className="flex justify-end pointer-events-auto">
-          <button
+          <button type="button"
             onClick={() => toasts.forEach((t) => removeToast(t.id))}
             className="flex items-center gap-1 rounded px-2 py-1 text-xs text-[var(--color-text-muted)] hover:text-[var(--color-text-primary)] transition-colors"
             aria-label={t("aria.dismissAll")}