Skip to content

refactor(acp-lifecycle-probe): split large acp-lifecycle-probe.ts into smaller modules #4235

Description

@OneStepAt4time

Observation: acp-lifecycle-probe.ts is ~1.5k LOC — too large for maintainability and testing. Large single-file modules cause review friction, accidental breakage, and risk when automated edits occur.\n\nRequest: investigate and split acp-lifecycle-probe.ts into focused modules (probe orchestration, health-check logic, host integration, retries/backoff, utilities). Keep behavior identical.\n\nDeliverables:\n- A list of logical submodules with file names and responsibilities (e.g., acp-lifecycle/orchestrator.ts, acp-lifecycle/host-probe.ts, acp-lifecycle/retries.ts, acp-lifecycle/metrics.ts).\n- A sequence of small PRs to refactor in place, each with unit tests and no behavior changes.\n- Add tests (unit + integration) covering the extracted pieces and CI gating.\n\nSuggested branch: refactor/acp-lifecycle-split\n\nPriority: P1 (high) — large file reduces team velocity and increases risk during hotfixes.\n\nIf you confirm, I will open a draft PR that extracts the first small module (utility helpers) and adds tests.\n

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4P4 — nice to have / backlogcireleasedIncluded in a published releasetests

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions